Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parsing of the function node in the serverless.yml #364

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@samueleresca
Copy link
Contributor

samueleresca commented Dec 17, 2018

Description of changes:
Added parsing for the function based serverless.yml definition. The YAML parser now can handle the following syntax :

# serverless.yml
service: myService

provider:
  name: aws
  runtime: dotnetcore2.1
  memorySize: 512 # will be inherited by all functions

functions:
  createfunction:
    handler: DotNetServerless.Lambda::DotNetServerless.Lambda.Functions.CreateItemFunction::Ru

As described in the getting started present in the serverless framework web site

Should we create a dedicated parser class for that?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samueleresca samueleresca changed the title Added paring of the function node in the serverless.yml Added parsing of the function node in the serverless.yml Dec 17, 2018

@normj

This comment has been minimized.

Copy link
Member

normj commented Dec 18, 2018

How is this PR different then the one I merged into the dev branch? #357

Also it looks like something went wrong with the gitignore. Files under Tools/LambdaTestTool/Amazon.Lambda.TestTool/ExternalCommands/App should not have been checked in as those are the build artifacts from Amazon.Lambda.TestTool.ExternalCommands.

@samueleresca

This comment has been minimized.

Copy link
Contributor Author

samueleresca commented Dec 18, 2018

Hi @normj , sorry I haven't noticed the Dlls in the App folder. Now it should be fine. The difference between this and the #357 is in the format of the serverless.yaml file.

Let me know

@slang25

This comment has been minimized.

Copy link
Contributor

slang25 commented Dec 19, 2018

Just to remove any doubt for readers, ServerlessTemplateYamlExample is the "AWS Serverless Transform", i.e. vanilla CloudFormation.
ServerlessFunctionTemplateYamlExample is the serverless framework. Who knew that would get confusing 😄

@normj

This comment has been minimized.

Copy link
Member

normj commented Dec 24, 2018

In case you were worried about not getting feedback in a bit. I'm on Christmas vacation and will catch up with this when I'm back in the office.

@normj normj merged commit 147c1ef into aws:dev Jan 10, 2019

@normj

This comment has been minimized.

Copy link
Member

normj commented Jan 10, 2019

Merged into dev so it will go out with the next release of the tool. I'll comment back on the PR when the release happens.

@samueleresca

This comment has been minimized.

Copy link
Contributor Author

samueleresca commented Jan 10, 2019

@normj Thanks 👍

@normj

This comment has been minimized.

Copy link
Member

normj commented Feb 7, 2019

Version 0.9.0 was released today with this PR. Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.