Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested changes for LambdaBootstrap testability #540

Merged
merged 5 commits into from Nov 6, 2019
Merged

Suggested changes for LambdaBootstrap testability #540

merged 5 commits into from Nov 6, 2019

Commits on Nov 3, 2019

  1. Support HttpClient injection 

    Support a user-provided HttpClient with LambdaBootstrap.
    @martincostello
    martincostello committed Nov 3, 2019
    Copy the full SHA
    f2cf315 View commit details
    Browse the repository at this point in the history

  2. Pass CancellationToken through to NextAsync 

    Pass the CancellationToken from LambdaBootstrap.RunAsync() through to IRuntimeApiClient.GetNextInvocationAsync() and catch OperationCanceledException in LambdaBootstrap and return.
    @martincostello
    martincostello committed Nov 3, 2019
    Copy the full SHA
    3a115e0 View commit details
    Browse the repository at this point in the history

  3. Only swallow cancelled exception if token signalled 

    Only swallow OperationCanceledException if IsCancellationRequested is true on the CancellationToken passed into the method by the caller.
    @martincostello
    martincostello committed Nov 3, 2019
    Copy the full SHA
    3f70fdd View commit details
    Browse the repository at this point in the history

  4. Do not dispose of HttpClient if passed in 

    Do not dispose of HttpClient if a value is provided through the constructor by the user. Only dispose if created by the instance itself.
    @martincostello
    martincostello committed Nov 3, 2019
    Copy the full SHA
    6945418 View commit details
    Browse the repository at this point in the history

  5. Add cancellation token to all runtime client methods 

    Add an optional CancellationToken argument to all IRuntimeApiClient methods.
    @martincostello
    martincostello committed Nov 3, 2019
    Copy the full SHA
    f2f3b97 View commit details
    Browse the repository at this point in the history