From 62a881eb48f628e77d4a69258acb51ce45b875d1 Mon Sep 17 00:00:00 2001 From: Jesse Date: Sat, 12 Oct 2019 06:10:08 +1300 Subject: [PATCH] Add phase-type of QUEUED as constant (#234) * Add phase-type of QUEUED as constant * Add to the test data also * fix assertions --- events/codebuild.go | 1 + events/codebuild_test.go | 19 ++++++++++++++++++- events/testdata/codebuild-phase-change.json | 8 ++++++++ events/testdata/codebuild-state-change.json | 8 ++++++++ 4 files changed, 35 insertions(+), 1 deletion(-) diff --git a/events/codebuild.go b/events/codebuild.go index 7a3b0d90..ca1dd33d 100644 --- a/events/codebuild.go +++ b/events/codebuild.go @@ -27,6 +27,7 @@ type CodeBuildPhaseType string const ( CodeBuildPhaseTypeSubmitted CodeBuildPhaseType = "SUBMITTED" + CodeBuildPhaseTypeQueued = "QUEUED" CodeBuildPhaseTypeProvisioning = "PROVISIONING" CodeBuildPhaseTypeDownloadSource = "DOWNLOAD_SOURCE" CodeBuildPhaseTypeInstall = "INSTALL" diff --git a/events/codebuild_test.go b/events/codebuild_test.go index 74101dda..bc03032d 100644 --- a/events/codebuild_test.go +++ b/events/codebuild_test.go @@ -2,10 +2,11 @@ package events import ( "encoding/json" - "github.com/stretchr/testify/require" "io/ioutil" "testing" "time" + + "github.com/stretchr/testify/require" ) func TestUnmarshalCodeBuildEvent(t *testing.T) { @@ -71,6 +72,14 @@ func TestUnmarshalCodeBuildEvent(t *testing.T) { PhaseType: CodeBuildPhaseTypeSubmitted, PhaseStatus: CodeBuildPhaseStatusSucceeded, }, + { + PhaseContext: []interface{}{}, + StartTime: CodeBuildTime(time.Date(2017, 9, 1, 16, 12, 29, 0, time.UTC)), + EndTime: CodeBuildTime(time.Date(2019, 9, 13, 4, 12, 29, 0, time.UTC)), + Duration: DurationSeconds(0), + PhaseType: CodeBuildPhaseTypeQueued, + PhaseStatus: CodeBuildPhaseStatusSucceeded, + }, { PhaseContext: []interface{}{}, StartTime: CodeBuildTime(time.Date(2017, 9, 1, 16, 12, 29, 0, time.UTC)), @@ -200,6 +209,14 @@ func TestUnmarshalCodeBuildEvent(t *testing.T) { PhaseType: CodeBuildPhaseTypeSubmitted, PhaseStatus: CodeBuildPhaseStatusSucceeded, }, + { + PhaseContext: []interface{}{}, + StartTime: CodeBuildTime(time.Date(2017, 9, 1, 16, 12, 29, 0, time.UTC)), + EndTime: CodeBuildTime(time.Date(2019, 9, 13, 4, 12, 29, 0, time.UTC)), + Duration: DurationSeconds(0), + PhaseType: CodeBuildPhaseTypeQueued, + PhaseStatus: CodeBuildPhaseStatusSucceeded, + }, { PhaseContext: []interface{}{}, StartTime: CodeBuildTime(time.Date(2017, 9, 1, 16, 12, 29, 0, time.UTC)), diff --git a/events/testdata/codebuild-phase-change.json b/events/testdata/codebuild-phase-change.json index e5744ae2..6de723ec 100644 --- a/events/testdata/codebuild-phase-change.json +++ b/events/testdata/codebuild-phase-change.json @@ -49,6 +49,14 @@ "phase-type": "SUBMITTED", "phase-status": "SUCCEEDED" }, + { + "phase-context": [], + "start-time": "Sep 1, 2017 4:12:29 PM", + "end-time": "Sep 13, 2019 4:12:29 AM", + "duration-in-seconds": 0.0, + "phase-type": "QUEUED", + "phase-status": "SUCCEEDED" + }, { "phase-context": [], "start-time": "Sep 1, 2017 4:12:29 PM", diff --git a/events/testdata/codebuild-state-change.json b/events/testdata/codebuild-state-change.json index 16ed65c8..4be1cb75 100644 --- a/events/testdata/codebuild-state-change.json +++ b/events/testdata/codebuild-state-change.json @@ -54,6 +54,14 @@ "phase-type": "SUBMITTED", "phase-status": "SUCCEEDED" }, + { + "phase-context": [], + "start-time": "Sep 1, 2017 4:12:29 PM", + "end-time": "Sep 13, 2019 4:12:29 AM", + "duration-in-seconds": 0.0, + "phase-type": "QUEUED", + "phase-status": "SUCCEEDED" + }, { "phase-context": [], "start-time": "Sep 1, 2017 4:12:29 PM",