GraalVM support #255

msailes · 2021-07-08T15:03:22Z

Issue #, if available:

Description of changes:
GraalVM config and regression test.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- aws-lambda-java-core - aws-lambda-java-serialization

…nfigMaker.

szab100 · 2021-09-16T16:48:55Z

Hi @msailes, what is this PR waiting for? We are facing with the same issues when trying to use spring native with graalvm..

msailes · 2021-09-16T18:26:19Z

@szab100 if possible could you contact me at msailes@amazon.co.uk

Thanks,

msailes · 2021-09-22T13:55:39Z

@szab100 could you 👍 this issue please. #272

stejsj · 2022-04-05T10:47:14Z

@msailes should the runtime client work with graalvm? We use scala and are trying to use your approach to get a native-image running to reduce cold start and resource requirements.

Sadly I get this error
START RequestId: 3a579869-9b96-46d7-9ce4-8c049a79d6c1 Version: $LATEST
[appconfig agent] 2022/04/05 10:36:21 INFO AppConfig Lambda Extension 2.0.45
[appconfig agent] 2022/04/05 10:36:21 INFO serving on localhost:2772
starting outage runtime...
Failed to load the native runtime interface client library aws-lambda-runtime-interface-client.glibc.so. Exception: null
Failed to load the native runtime interface client library aws-lambda-runtime-interface-client.musl.so. Exception: null
EXTENSION Name: AppConfigAgent State: Ready Events: [SHUTDOWN,INVOKE]
END RequestId: 3a579869-9b96-46d7-9ce4-8c049a79d6c1
REPORT RequestId: 3a579869-9b96-46d7-9ce4-8c049a79d6c1 Duration: 253.23 ms Billed Duration: 254 ms Memory Size: 2048 MB Max Memory Used: 56 MB
XRAY TraceId: 1-624c1ba4-441854bd0da7b1425ca04379 SegmentId: 14184b9f35ddfe28 Sampled: true

Eventhough I tried to manually include those two libraries as native-image resource args
example -H:IncludeResources="+baseDirectory.value / "src" / "main" / "resources" / "META-INF" / "resources" / "aws-lambda-runtime-interface-client.glibc.so"

We have been struggling quite a lot getting this to work, any thoughts, hints or ideas?

Thanx in advance
Steffen

msailes · 2022-04-05T12:03:31Z

Hi @stejsj ,

It is not currently supported no. The best thing to do would be to copy the config files from this sample application.

https://github.com/aws-samples/serverless-graalvm-demo/tree/main/software/products/src/main/resources/META-INF/native-image

stejsj · 2022-04-05T13:43:41Z

Thanks @msailes I actually allready did that, but native-image fails when i provide the config param -H:ReflectionConfigurationResources="+ baseDirectory.value / "src" / "main" / "resources" / "META-INF" / "native-image" / "com.amazonaws/aws-lambda-java-runtime-interface-client/resource-config.json"

It says it cannot find the two mentioned files, I then tried to add them as resources with full path but still got the same error when testing the lambda in the console...

"-H:IncludeResources="+baseDirectory.value / "src" / "main" / "resources" / "META-INF" / "resources" / "aws-lambda-runtime-interface-client.glibc.so","-H:IncludeResources="+baseDirectory.value / "src" / "main" / "resources" / "META-INF" / "resources" / "aws-lambda-runtime-interface-client.musl.so"

So somehow I may have missed up when converting the java / maven example to scala + sbt :-(

Been struggling quite a bit so would really love to get it working, Now I try with our own implementation of custom runtime, but that lacks many of the features and support for lambda that this project should provide

Thanks once again
Steffen

msailes · 2022-04-05T14:23:19Z

I don't know much about sbt, the maven plugin just knows to look in a set location. I'm guessing that's different for your situation. I would recommend asking in the GraalVM slack, they have a channel just for native-image.

https://www.graalvm.org/slack-invitation/

stejsj · 2022-04-05T14:38:22Z

@msailes thank you will try that

carlzogh · 2022-05-26T13:27:15Z

.../main/resources/META-INF/native-image/com/amazonaws/aws-lambda-java-core/reflect-config.json

+[
+{
+  "name":"com.amazonaws.services.lambda.runtime.LambdaRuntime",
+  "methods":[{"name":"<init>","parameterTypes":[] }],
+  "fields":[{"name":"logger"}],
+  "allPublicMethods":true
+},
+{
+  "name":"com.amazonaws.services.lambda.runtime.LambdaRuntimeInternal",
+  "methods":[{"name":"<init>","parameterTypes":[] }],
+  "allPublicMethods":true
+}
+]


Is this file needed if we have the dynamic Feature?

carlzogh · 2022-05-26T13:54:07Z

...INF/native-image/com.amazonaws/aws-lambda-java-runtime-interface-client/resource-config.json

+{
+  "resources":{
+  "includes":[
+    {"pattern":"\\Qaws-lambda-runtime-interface-client.glibc.so\\E"}, 
+    {"pattern":"\\Qaws-lambda-runtime-interface-client.musl.so\\E"}
+  ]},
+  "bundles":[]
+}


Can this be dynamically generated?

carlzogh · 2022-05-26T13:54:18Z

...-INF/native-image/com.amazonaws/aws-lambda-java-runtime-interface-client/reflect-config.json

+[
+{
+  "name":"java.lang.Void",
+  "methods":[{"name":"<init>","parameterTypes":[] }]
+},
+{
+  "name":"java.util.Collections$UnmodifiableMap",
+  "fields":[{"name":"m"}]
+},
+{
+  "name":"jdk.internal.module.IllegalAccessLogger",
+  "fields":[{"name":"logger"}]
+},
+{
+  "name":"sun.misc.Unsafe",
+  "fields":[{"name":"theUnsafe"}]
+}
+]


Do we need to define reflect-config for JDK internal methods and classes?

carlzogh · 2022-05-26T13:55:11Z

...mbda-java-runtime-interface-client/test/integration/codebuild-local/Dockerfile.graalvm-agent

+    && rm -rf /var/cache/yum
+
+
+ENV GRAAL_VERSION 21.1.0


Can we share this value with the one we define in pom.xml?

carlzogh · 2022-05-26T13:55:33Z

aws-lambda-java-runtime-interface-client/test/integration/graalvm-test-handler/pom.xml

+    <dependencies>
+        <dependency>
+            <groupId>com.amazonaws</groupId>
+            <artifactId>aws-lambda-java-runtime-interface-client</artifactId>
+            <version>1.1.0</version>
+        </dependency>
+        <dependency>
+            <groupId>com.amazonaws</groupId>
+            <artifactId>aws-lambda-java-events</artifactId>
+            <version>3.9.0</version>
+        </dependency>
+    </dependencies>


outdated dependencies

carlzogh · 2022-05-26T13:59:06Z

...client/test/integration/graalvm-test-handler/src/main/java/helloworld/RequestHandlerApp.java

+    {
+        try{
+            //test to make sure all events are available
+            Class.forName("com.amazonaws.services.lambda.runtime.events.CloudFrontEvent");


For completeness, this handler should ensure that all methods/classes that are accessible outside of the native-image are also accessible within the native-image. Maybe we could achieve this by running a JAR handler before this one to generate a list of all reachable entities and pass this in as an event payload to this function handler, that will in turn try to load them all

carlzogh · 2022-05-26T13:59:37Z

...ntegration/graalvm-test-handler/src/main/resources/META-INF/native-image/reflect-config.json

+    "allDeclaredConstructors": true,
+    "allPublicConstructors": true,
+    "allDeclaredMethods": true,
+    "allPublicMethods": true,
+    "allDeclaredClasses": true,
+    "allPublicClasses": true


Do we need allDeclared as opposed to just allPublic?

carlzogh · 2022-05-26T14:02:01Z

.../src/main/java/com/amazonaws/services/lambda/runtime/graalvm/LambdaEventsGraalVMFeature.java

+public class LambdaEventsGraalVMFeature implements Feature {
+
+    public static final String EVENTS_PACKAGE_NAME = "com.amazonaws.services.lambda.runtime.events";


I think we should make this generic enough for it to be reused across all our libraries in this project, and move it out of the runtime addressable scope. It should be a build-only class that is not exposed in the library.

This is essentially boilerplate code that will traverse our libraries and determine what the appropriate native-image config is, so we don't really need a copy of it per project.

carlzogh · 2022-05-26T14:03:37Z

...META-INF/native-image/com.amazonaws/aws-lambda-java-runtime-interface-client/jni-config.json

+[
+{
+  "name":"com.amazonaws.services.lambda.runtime.api.client.runtimeapi.LambdaRuntimeClientException",
+  "methods":[{"name":"<init>","parameterTypes":["java.lang.String","int"] }]
+},
+{
+  "name":"com.amazonaws.services.lambda.runtime.api.client.runtimeapi.InvocationRequest",
+  "fields":[{"name":"id"}, {"name":"invokedFunctionArn"}, {"name":"deadlineTimeInMs"}, {"name":"xrayTraceId"}, {"name":"clientContext"}, {"name":"cognitoIdentity"}, {"name":"content"}],
+  "allPublicMethods":true
+}
+]


Can this be auto-generated like reflect-config.json?

carlzogh · 2022-05-26T14:06:04Z

...-runtime-interface-client/test/integration/codebuild-graalvm/buildspec.os.amazoncorretto.yml

+  build:
+    commands:
+      - set -x
+      - echo "Running Image ${IMAGE_TAG}"
+      - docker network create "${OS_DISTRIBUTION}-network"
+      - >


Some parts of this script have been refactored, we should update this

msailes added 14 commits June 4, 2021 13:10

GraalVM support for

50ff815

- aws-lambda-java-core - aws-lambda-java-serialization

native-image support for the events lib

ce27b2e

reflect-config.json not needed for events lib.

9e11dab

added joda datetime

71279ee

Adding GraalVM reflect-config.json and tests to catch any regressions.

567d59c

trying out a single graalvm task

c85b0a3

trying out a single graalvm task

693bbc8

add manually running jobs

ae2af66

add manually running jobs

8a34d28

add manually running jobs

602180e

quiet maven

837b38f

graalvm

1e42782

might work

80ea23c

app config

a67cabf

msailes self-assigned this Jul 12, 2021

clean up

187cebf

msailes changed the title ~~Graalvm support~~ GraalVM support Jul 12, 2021

msailes added 6 commits July 12, 2021 11:29

typo

c4c8661

removed reference to my dockerfile

a81c1fc

merged Richard's LambdaEventsGraalVMFeature and removed the GraalVMCo…

33060df

…nfigMaker.

removing graalvm from the pr make

9430ae3

Adding updated README.md from fafriat

6c7ce8d

improving the java docs

c5b928f

msailes mentioned this pull request Jul 13, 2021

Provide configuration for native compilation using graalvm native-image #208

Closed

msailes and others added 6 commits July 14, 2021 08:56

adding the Feature for Core

c9479ad

Add GraalVM test for StreamHandler

e68cbb1

ignore .DS_Store

a266a67

Merge branch 'graalvm-support' of https://github.com/msailes/aws-lamb…

2df8a6e

…da-java-libs into graalvm-support

Move GraalVM reflect-config.json to GraalVM features

47bbe1e

adding Javadocs to explain the Feature classes.

612c5a9

msailes mentioned this pull request Jul 15, 2021

Programmatically register Lambda event classes with GraalVM #252

Closed

msailes and others added 3 commits July 15, 2021 11:25

adding the compile time graalvm dependency.

ff795e6

moving the graalvm sdk to provided.

c27cb9a

Merge branch 'master' into graalvm-support

200d5b8

carlzogh suggested changes May 26, 2022

View reviewed changes

msailes reopened this Aug 16, 2022

anton-stepanof deleted the branch aws:master January 3, 2023 18:00

anton-stepanof closed this Jan 3, 2023

		public class LambdaEventsGraalVMFeature implements Feature {

		public static final String EVENTS_PACKAGE_NAME = "com.amazonaws.services.lambda.runtime.events";

GraalVM support #255

GraalVM support #255

Uh oh!

Conversation

msailes commented Jul 8, 2021

Uh oh!

szab100 commented Sep 16, 2021

Uh oh!

msailes commented Sep 16, 2021

Uh oh!

msailes commented Sep 22, 2021

Uh oh!

stejsj commented Apr 5, 2022

Uh oh!

msailes commented Apr 5, 2022

Uh oh!

stejsj commented Apr 5, 2022

Uh oh!

msailes commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stejsj commented Apr 5, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

msailes commented Apr 5, 2022 •

edited

Loading