Be nice to more standard http servers. #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle HTTP status codes coming from the runtime server in a way that plays nice with local development tools like the runtime interface emulator. Signed-off-by: David Calavera <david.calavera@gmail.com>
rimutaka
reviewed
Mar 17, 2022
| let event = next_event_response?; | ||
| let (parts, body) = event.into_parts(); | ||
|
|
||
| if parts.status == http::StatusCode::NO_CONTENT { |
Contributor
There was a problem hiding this comment.
Can an AWS server return this status? If not, should this be under an optional flag or for debug only?
Contributor
Author
There was a problem hiding this comment.
why should we complicate it more than this?
Signed-off-by: David Calavera <david.calavera@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle HTTP status codes coming from the runtime server
in a way that plays nice with local development tools
like the runtime interface emulator.
Signed-off-by: David Calavera david.calavera@gmail.com
By submitting this pull request