lambda_http: Add convenience methods to get references to data in the request #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcormier
commented
Feb 17, 2023
Contributor
Author
|
I'm inclined to have those two methods I commented on return |
Collaborator
|
Thanks for contributing. I agree returning |
Contributor
Author
|
Done. |
Collaborator
|
Could you merge the latest main branch into this PR? It contains fixes for clippy issues and won't break the builds. |
There are existing methods to get owned clones of various pieces of data in the `Request`. This adds methods to get references where owned data is not needed.
Contributor
Author
|
Done. |
bnusunny
approved these changes
Feb 21, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There are existing methods to get owned clones of various pieces of data in the
Request. This adds methods to get references where owned data is not needed.Also fixed a typo in docs, and some typos in tests.
By submitting this pull request