Update function to avoid division #1360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a reference where the fix comes from to the PR description and to the Readme file in kyber directory. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1360 +/- ##
==========================================
- Coverage 76.79% 76.73% -0.07%
==========================================
Files 422 422
Lines 71249 71252 +3
==========================================
- Hits 54719 54676 -43
- Misses 16530 16576 +46 ☔ View full report in Codecov by Sentry. |
Fix taken from [this commit][1]. [1]: pq-crystals/kyber@dda29cc
WillChilds-Klein
force-pushed
the
avoid-division
branch
from
636e900 to
93da5d5
Compare
dkostic
approved these changes
Dec 16, 2023
andrewhop
approved these changes
Dec 16, 2023
Merged
skmcgrail
pushed a commit
to skmcgrail/aws-lc
that referenced
this pull request
Dec 18, 2023
Fix taken from [this commit][1]. [1]: pq-crystals/kyber@dda29cc (cherry picked from commit 17cd657)
skmcgrail
added a commit
that referenced
this pull request
Dec 18, 2023
…rsion to 2.0.3 (#1366) * Bump version to 2.0.3 * Make the AES-GCM avx512 Perl script compatible with old Perl (#960) (cherry picked from commit 44a1c47) * Update function to avoid division (#1360) Fix taken from [this commit][1]. [1]: pq-crystals/kyber@dda29cc (cherry picked from commit 17cd657) --------- Co-authored-by: Dengke Tang <815825145@qq.com> Co-authored-by: Will Childs-Klein <childw@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Fix taken from this commit.
Addresses:
t/P109267011
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.