Update poly_compress and polyvec_compress to prevent the compiler from using DIV #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… polyvec_compress to prevent the compiler from using DIV.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1376 +/- ##
==========================================
- Coverage 76.84% 76.80% -0.04%
==========================================
Files 424 424
Lines 71392 71410 +18
==========================================
- Hits 54859 54846 -13
- Misses 16533 16564 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WillChilds-Klein
approved these changes
Jan 2, 2024
nebeid
approved these changes
Jan 2, 2024
andrewhop
pushed a commit
to andrewhop/aws-lc
that referenced
this pull request
Jan 3, 2024
… polyvec_compress to prevent the compiler from using DIV. (aws#1376)
Closed
geedo0
pushed a commit
to geedo0/aws-lc
that referenced
this pull request
Jan 3, 2024
… polyvec_compress to prevent the compiler from using DIV. (aws#1376)
dougch
pushed a commit
to dougch/aws-lc
that referenced
this pull request
Jan 30, 2024
… polyvec_compress to prevent the compiler from using DIV. (aws#1376)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This patch mirrors the technique used in the upstream Kyber reference code (commit 272125f) to prevent the compiler from using the DIV instruction in
poly_compressandpolyvec_compress.Addresses t/V1179892555.
Testing:
CI testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.