Skip to content

Conversation

@nebeid
Copy link
Contributor

@nebeid nebeid commented Oct 30, 2025

Description of changes:

w19 was set to its fixed value 0x87 after the code jumps to the case of cipher stealing of 1 block and a tail.

  • This bug was introduced in v1.62 in "Move udiv and sencond tweak calculations to when needed" by @nebeid in #2726 where the setting of w19 was moved past the branch to .Lxts_enc_tail1x.
  • Also the 3 test vectors that tested 1 block + tail were not lucky enough to exercise this issue which happens when the encrypted tweak, when shifted left by 1, results in a bit of 1, which, in turn, results in XORing the value 0x87 with the tweak.

Testing:

The failing tests are now passing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@nebeid nebeid requested a review from a team as a code owner October 30, 2025 00:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.52%. Comparing base (03d44c8) to head (5e4a01f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2785   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files         678      678           
  Lines      115344   115344           
  Branches    16327    16330    +3     
=======================================
  Hits        90572    90572           
+ Misses      23978    23977    -1     
- Partials      794      795    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nebeid nebeid merged commit 3f282aa into aws:main Oct 30, 2025
365 of 387 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants