Add EVP_bf_cfb64 #2851
Add EVP_bf_cfb64 #2851
Conversation
nhatnghiho
force-pushed
the
evp-bf-cfb64
branch
from
282f56f to
f69590c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| SCOPED_TRACE(test_num); | ||
|
|
||
| uint8_t out[sizeof(test.cfb_ciphertext)]; | ||
| int out_bytes, final_bytes; |
There was a problem hiding this comment.
warning: variable 'final_bytes' is not initialized [cppcoreguidelines-init-variables]
| int out_bytes, final_bytes; | |
| int out_bytes, final_bytes = 0; |
| SCOPED_TRACE(test_num); | ||
|
|
||
| uint8_t out[sizeof(test.cfb_ciphertext)]; | ||
| int out_bytes, final_bytes; |
There was a problem hiding this comment.
warning: variable 'out_bytes' is not initialized [cppcoreguidelines-init-variables]
| int out_bytes, final_bytes; | |
| int out_bytes = 0, final_bytes; |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2851 +/- ##
=======================================
Coverage 78.24% 78.25%
=======================================
Files 683 683
Lines 117346 117362 +16
Branches 16488 16487 -1
=======================================
+ Hits 91821 91836 +15
- Misses 24641 24642 +1
Partials 884 884 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| const EVP_CIPHER *EVP_bf_cfb64(void) { return &bf_cfb; } |
There was a problem hiding this comment.
I think this is the only required change in this file, with the others just being formatting. To reduce the noise, could the non-essential changes above be reverted?
There was a problem hiding this comment.
It's my autoformatter using our clang-format config. But I'd imagine that anyone with the same formatting config will also inadvertently change the file later on?
4 participants
Description of changes:
Add
EVP_bf_cfb64cipher to public APITesting:
Unit test added
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.