[Cherry-pick FIPS 2025] Route ML-DSA ACVP to the right APIs #2890
+39
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description of changes: The previous ML-DSA change weren't routing against the right APIs. This fixes that. Issues were mainly: 1. `extmu` is exclusive to `signatureInterface=internal`, but we were passing in false for `signatureInterface=external`. 2. `ml_dsa_*_sign` APIs are non-deterministic and we weren't passing in `rnd` as the random bytes. This routes the SignGen tests to the right places. ### Call-outs: N/A ### Testing: New ACVP demo vector, verified against expected outputs and added to this change. The new tests fail without the new changes made to ACVP. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 745d009)
torben-hansen
approved these changes
Dec 8, 2025
dkostic
approved these changes
Dec 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fips-2025-09-12 #2890 +/- ##
===================================================
- Coverage 78.69% 78.69% -0.01%
===================================================
Files 667 667
Lines 113027 113027
Branches 16069 16068 -1
===================================================
- Hits 88951 88947 -4
- Misses 23302 23306 +4
Partials 774 774 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picked from commit on main: 745d009
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.