From fa7cb51caccf161c4920bbcd87e5b8c5889d8a84 Mon Sep 17 00:00:00 2001 From: hanwenli Date: Tue, 20 May 2025 11:29:21 -0700 Subject: [PATCH] [test] Reenable install_munge_folders_created check Among the original three folders checked, this commit removes the check on `/var/run/munge`. `/var/run` content changes across reboots. The check was successful on validate phase because there was no reboot between validate phase and build phase. The check fails on test phase because build and test are running on different instances Signed-off-by: Hanwen --- .../test/controls/munge_spec.rb | 32 ++++++++----------- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/cookbooks/aws-parallelcluster-slurm/test/controls/munge_spec.rb b/cookbooks/aws-parallelcluster-slurm/test/controls/munge_spec.rb index 1a15a353cc..fdf257cf9a 100644 --- a/cookbooks/aws-parallelcluster-slurm/test/controls/munge_spec.rb +++ b/cookbooks/aws-parallelcluster-slurm/test/controls/munge_spec.rb @@ -35,25 +35,19 @@ end end unless os_properties.redhat_on_docker? -# FIXME: Re-enabled the following check and fix failures -# control 'tag:install_munge_folders_created' do -# title 'Munge folder have been created' -# -# describe file('/var/log/munge') do -# it { should exist } -# it { should be_directory } -# end -# -# describe file('/etc/munge') do -# it { should exist } -# it { should be_directory } -# end -# -# describe file('/var/run/munge') do -# it { should exist } -# it { should be_directory } -# end -# end unless os_properties.redhat_on_docker? +control 'tag:install_munge_folders_created' do + title 'Munge folder have been created' + + describe file('/var/log/munge') do + it { should exist } + it { should be_directory } + end + + describe file('/etc/munge') do + it { should exist } + it { should be_directory } + end +end unless os_properties.redhat_on_docker? control 'tag:config_munge_service_enabled' do only_if { node['cluster']['scheduler'] == 'slurm' && !os_properties.redhat_on_docker? }