Skip to content

Conversation

@mtfranchetto
Copy link
Contributor

Description

Fixes #181.

Changes

Override breadcrumb navigation using react-router-dom instead of a page reload (took inspiration from the sidebar).

How Has This Been Tested?

  • Clicked on many breadcrumb items: no page reload and the region is preserved
  • Started a cluster creation and clicked on a breadcrumb: the user is redirected to cluster and form data is resetted

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I made sure that any GitHub issue solved by this PR is correctly linked
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mtfranchetto mtfranchetto merged commit 1b4c3df into main May 15, 2023
@mtfranchetto mtfranchetto deleted the bugfix/preserve-region-breadcrumbs branch May 15, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking the cluster-name breadcrumb does not preserve region

2 participants