Skip to content

Conversation

@mendaomn
Copy link
Contributor

@mendaomn mendaomn commented Mar 7, 2023

Description

This PR adds the Create cluster button dropdown, to be adopted in a future PR.

It follows the work done with #90 and #84

Changes

  • add CreateButtonDropdown component
  • connect the dropdown options to the HiddenFileUpload and the FromClusterModal

Screenshot

image

How Has This Been Tested?

  • manually
  • unit test
  • file upload will be tested with e2e tests once the CreateButtonDropdown will be adopted

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mendaomn mendaomn requested a review from mtfranchetto March 7, 2023 14:20
Copy link
Contributor

@mtfranchetto mtfranchetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mendaomn !

@lazyoft lazyoft merged commit 7cd6424 into main Mar 7, 2023
@lazyoft lazyoft deleted the add-dropdown-button-standalone branch March 7, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants