Skip to content

Conversation

@mendaomn
Copy link
Contributor

@mendaomn mendaomn commented Mar 7, 2023

Description

This PR adds a dropdown button to pick the source from which to create a cluster. It replaces the Source section of the wizard.

It builds upon the work done with #93
Closes #32
Closes #34

A follow up PR will remove the inactive code of the Source page

Changes

  • remove source from the steps of the wizard
  • add dropdown button to /clusters page
  • align e2e tests

How Has This Been Tested?

  • manually
    • uploaded a template, checked that the final config matches with the uploaded one
    • create from cluster, checked that the final config matches with the source cluster
  • e2e tests

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mendaomn mendaomn force-pushed the adopt-dropdown-button branch from e079e69 to 47a82d5 Compare March 8, 2023 08:52
mtfranchetto
mtfranchetto previously approved these changes Mar 8, 2023
Copy link
Contributor

@mtfranchetto mtfranchetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just do a round of tests when editing a cluster since it has been affected too by the changes

@mendaomn mendaomn marked this pull request as draft March 8, 2023 10:03
@mendaomn mendaomn marked this pull request as ready for review March 8, 2023 11:24
@mendaomn mendaomn requested a review from mtfranchetto March 8, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants