ci(package): NamedTemporaryFile Being Opened Twice #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoshUS
changed the title
jfuss
reviewed
Jan 29, 2021
| @@ -131,6 +131,10 @@ def test_package_template_with_image_function_in_nested_application(self, templa | |||
| # when image function is not in main template, erc_repo_name does not show up in stdout | |||
| # here we download the nested application template file and verify its content | |||
| with tempfile.NamedTemporaryFile() as packaged_file, tempfile.TemporaryFile() as packaged_nested_file: | |||
| # https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile | |||
| # Closes the NamedTemporaryFile as on Windows NT or later, NamedTemporaryFile cannot be opened twice. | |||
| packaged_file.close() | |||
There was a problem hiding this comment.
Why not use TemporaryFile() for package_file?
There was a problem hiding this comment.
TemporaryFile does not guarantee the file is visible in the file system on Unix. We need to read the file later using packaged_file.name in order to validate the output.
There was a problem hiding this comment.
We need a visible name for package_file in the file system, which is used for output_template_file in the command.
TemporaryFile() does not guarantee a visible name in the file system.
We don't need the file to actually exist though. Since the command will create the file again
jfuss
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
In Windows NT or later, NamedTemporaryFile cannot be opened twice.
https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.