New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow invoking built CDK synthesized templates #3549
feat: allow invoking built CDK synthesized templates #3549
Conversation
…e-built-cdk-templates' into develop-invoke-built-cdk-templates
…e-built-cdk-templates' into develop-invoke-built-cdk-templates
) | ||
return customer_defined_id | ||
|
||
resource_cdk_path = resource_metadata.get(RESOURCE_CDK_PATH_METADATA_KEY) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method and filename is named generic (resource_metadata_normalizer
and get_resource_id
), but method itself contains CDK specific stuff. This feels like it should be a generic (let's say ResourceMetadataNormalizer
) class and we should be assigning different types depending on the project type (CfnResourceMetadataNormalizer
or CdkResourceMetadataNormalizer
), what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am working on another PR that is related to this part (IaC ids) to use it in other commands. Can I work on this refactoring after I merge this PR, and the one I am working on, as I do not want to miss things, it will be easier to refactor everything together
…p-invoke-built-cdk-templates # Conflicts: # tests/unit/lib/samlib/test_resource_metadata_normalizer.py
* feat: allow invoking built CDK synthesized templates * run black * fixing testing issue * add unit testing to cover custom resource Id * run black * skip normalizing the resources that have been normalized before * apply pr comments * apply pr comments
Which issue(s) does this change fix?
allow invoking built CDK synthesized templates
Checklist
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.