Made responses in Getting Started code into valid Proxy Integration r… #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanathkr
suggested changes
Aug 17, 2017
HOWTO.md
Outdated
| @@ -58,23 +58,23 @@ exports.handler = (event, context, callback) => { | |||
| case "GET": | |||
|
|
|||
| if(id) { | |||
| callback(null, "This is a READ operation on product ID " + id); | |||
| callback(null, { body: "This is a READ operation on product ID " + id}); | |||
There was a problem hiding this comment.
Awesome! It is generally a good practice to manually return statusCode = 200 for successful calls. Can you make that change as well?
|
Thanks for doing this! |
|
Glad I could help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…esponses
Running through the HOWTO.md as stated, I got
ERROR: Function Products returned an invalid response (must include one of: body, headers or statusCode in the response object)as a result of runningcurl http://localhost:3000/products, because the responses in the callback aren't valid Proxy Integration responses. This change simply puts those original responses into the body of a JSON object.