Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to smithy 1.25.0 #1835

Merged
merged 2 commits into from Sep 14, 2022
Merged

Upgrade to smithy 1.25.0 #1835

merged 2 commits into from Sep 14, 2022

Conversation

syall
Copy link
Contributor

@syall syall commented Sep 7, 2022

Dependent on Smithy 1.25.0 release and aws/smithy-go#386, BLOCK merging until then.

For changes to files under the /model/ folder, and manual edits to autogenerated code (e.g. /service/s3/api.go) please create an Issue instead of a PR for those type of changes.

N/A


If there is an existing bug or feature this PR is answers please reference it here.

N/A


Description of changes:

Note: This change introduces break/fix's for pointable types.

Update EC2 unboxed shapes to boxed shapes backfill customization

Due to changes in smithy 2.0 nullability semantics around the @box trait, the generated code for ec2.json generated incorrect code.

Instead of adding @box traits to certain members in the customization, the @clientOptional trait is added to members of all structure shapes.

Chores:

  • Add mavenLocal to codegen build files
  • Update .gitignore to ignore .idea/

Regenerate clients with break/fix's

Due to prior bugs for @box members not being serialized as a pointer type and incorrect pagination serialization, the clients in this commit are regenerated with the break/fix's.


Testing:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@syall syall requested a review from a team as a code owner Sep 7, 2022
syall added 2 commits Sep 13, 2022
Update EC2 unboxed shapes to boxed shapes backfill customization

Due to changes in smithy 2.0 nullability semantics around the
`@box` trait, the generated code for `ec2.json` generated
incorrect code.

Instead of adding `@box` traits to certain members in the
customization, the `@clientOptional` trait is added to members
of all structure shapes.

Chores:

- Add mavenLocal to codegen build files
- Update .gitignore to ignore .idea/
Due to prior bugs for `@box` members not being serialized as a
pointer type and incorrect pagination serialization, the clients
in this commit are regenerated with the break/fix's.
jasdel
jasdel approved these changes Sep 14, 2022
@jasdel jasdel merged commit a13b7a4 into aws:main Sep 14, 2022
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants