Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify home dir logic between shared config and sso #1960

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

isaiahvita
Copy link
Contributor

@isaiahvita isaiahvita commented Dec 14, 2022

In order to allow for sso unit tests to pass on certain build testing hosts, we needed to fix how the SSO module finds the home directory. This solution is to take the logic (for grabbing a home dir) from shared config. move it to internal shareddefaults. and then use shareddefaults for both sso and shared config

@isaiahvita isaiahvita requested a review from a team as a code owner December 14, 2022 21:07
@isaiahvita isaiahvita merged commit 6067fb2 into main Dec 15, 2022
@isaiahvita isaiahvita deleted the isvita/home-dir-fix branch February 24, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants