Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`service`: Adds prototyped operations from APIGateWay and S3 service that uses rest encoder utility #452

Closed
wants to merge 13 commits into from

Conversation

@skotambkar
Copy link
Member

skotambkar commented Dec 6, 2019

  • Adds prototype for getApiKey request for apigateway service and putObject request for s3 service that use rest encoder utility from PR aws/aws-sdk-go-v2#449
  • This PR adds changes on top of changes added for PR aws/aws-sdk-go-v2#441, also takes in changes from PR aws/aws-sdk-go-v2#449.
  • We add Marshal.go for service/apigateway & service/s3. It contains prototyped marshaler operations and functions for respective operations.
  • We also add test to compare the marshaled request using rest encoder utility with the old rest marshaler.
@skotambkar skotambkar changed the title service/apigateway`: Adds prototyped GetAPIKeyRequest that uses rest encoder utility `service`: Adds prototyped GetAPIKeyRequest & PutObjectRequest that uses rest encoder utility Dec 6, 2019
@skotambkar skotambkar changed the title `service`: Adds prototyped GetAPIKeyRequest & PutObjectRequest that uses rest encoder utility `service`: Adds prototyped operations from APIGateWay and S3 service that uses rest encoder utility Dec 6, 2019
@skotambkar skotambkar force-pushed the skotambkar:prototype/apigateway branch from ce31d91 to b6e36c0 Dec 6, 2019
@skotambkar skotambkar marked this pull request as ready for review Dec 6, 2019
@skotambkar skotambkar requested review from jasdel and skmcgrail Dec 6, 2019
@skotambkar skotambkar force-pushed the skotambkar:prototype/apigateway branch from b6e36c0 to 77999c9 Dec 6, 2019
Copy link
Member

jasdel left a comment

Once the types packages is merged in it will be easier to review this prototype :)

@skotambkar skotambkar force-pushed the skotambkar:prototype/apigateway branch from c1ec6c7 to 552ffa2 Dec 11, 2019
@jasdel

This comment has been minimized.

Copy link
Member

jasdel commented Dec 31, 2019

For this PR what do you think about moving the apigateway/internal/awsrestjson package content into the API client's package, apigateway?. This would allow us to continue making progress on marshaling prototypes and merge this PR before we finalize on the client's package structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.