Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upprivate/protocol: adding generated marshalers #76
Conversation
xibz
requested a review
from
jasdel
Dec 26, 2017
xibz
force-pushed the
xibz:master
branch
2 times, most recently
from
3917efc
to
a1fd09b
Dec 26, 2017
jasdel
referenced this pull request
Dec 27, 2017
Closed
API Marshaler: Fix RESTXML protocol marshaler code generation for locationName #1554
This comment has been minimized.
This comment has been minimized.
|
Could you expand this PR description to describe the change being made and its impact? Also which protocols are being impacted by this change. Similar idea to aws/aws-sdk-go#1409. It would be helpful to include up-to-date performance metric impact as well. It would also be helpful for historical purposes if this also referenced aws/aws-sdk-go#1554 that this change was ported from. |
xibz
force-pushed the
xibz:master
branch
from
a1fd09b
to
e0f3ed5
Jan 25, 2018
xibz
closed this
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
xibz commentedDec 26, 2017
No description provided.