New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private/protocol: adding generated marshalers #76

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@xibz
Copy link
Contributor

xibz commented Dec 26, 2017

No description provided.

@xibz xibz requested a review from jasdel Dec 26, 2017

@xibz xibz force-pushed the xibz:master branch 2 times, most recently from 3917efc to a1fd09b Dec 26, 2017

@jasdel

This comment has been minimized.

Copy link
Member

jasdel commented Dec 27, 2017

Could you expand this PR description to describe the change being made and its impact? Also which protocols are being impacted by this change. Similar idea to aws/aws-sdk-go#1409. It would be helpful to include up-to-date performance metric impact as well.

It would also be helpful for historical purposes if this also referenced aws/aws-sdk-go#1554 that this change was ported from.

@xibz xibz force-pushed the xibz:master branch from a1fd09b to e0f3ed5 Jan 25, 2018

@xibz xibz closed this Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment