Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port V1 S3 Transfer Manager to V2 #802

Merged
merged 8 commits into from Oct 14, 2020
Merged

Port V1 S3 Transfer Manager to V2 #802

merged 8 commits into from Oct 14, 2020

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Oct 8, 2020

Fresh port of the V1 S3 Transfer Manager s3manager to the V2 smithy design.

Fixes #783

@skmcgrail skmcgrail changed the title Port V1 S3 Transfer Manager to V2 Smithy Port V1 S3 Transfer Manager to V2 Smithy Client Oct 8, 2020
@skmcgrail skmcgrail changed the title Port V1 S3 Transfer Manager to V2 Smithy Client Port V1 S3 Transfer Manager to V2 Oct 8, 2020
@skmcgrail skmcgrail force-pushed the portS3Manager branch 5 times, most recently from b048dbe to 0c627a7 Compare October 12, 2020 17:07
@skmcgrail skmcgrail requested a review from jasdel October 12, 2020 23:51
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like an accidental compiled test added to changes

s3manager/internal/integration/downloader/downloader.test 
s3manager/internal/integration/uploader/uploader.test 

aws/http_client.go Outdated Show resolved Hide resolved
@skmcgrail skmcgrail merged commit d6986a7 into master Oct 14, 2020
@skmcgrail skmcgrail deleted the portS3Manager branch November 9, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is the suggested replacement for s3manager, including Uploader & Downloader in 0.25.0
2 participants