From 225097cc889350c51e00536bfc5ed30d89f0ff35 Mon Sep 17 00:00:00 2001 From: Isaiah Vita <82135527+isaiahvita@users.noreply.github.com> Date: Wed, 10 May 2023 09:04:22 -0700 Subject: [PATCH] remove deprecated service AWS SMS integ tests (#4834) --- CHANGELOG_PENDING.md | 3 ++ private/model/cli/gen-api/main.go | 4 +- service/sms/integ_test.go | 66 ------------------------------- 3 files changed, 6 insertions(+), 67 deletions(-) delete mode 100644 service/sms/integ_test.go diff --git a/CHANGELOG_PENDING.md b/CHANGELOG_PENDING.md index 8a1927a39ca..a7039eda5b2 100644 --- a/CHANGELOG_PENDING.md +++ b/CHANGELOG_PENDING.md @@ -3,3 +3,6 @@ ### SDK Enhancements ### SDK Bugs + +* `service/sms`: Remove deprecated services (SMS) integration tests. + * SMS integration tests will fail because SMS deprecated their service. \ No newline at end of file diff --git a/private/model/cli/gen-api/main.go b/private/model/cli/gen-api/main.go index 5bb58b08a34..12a7995dae4 100644 --- a/private/model/cli/gen-api/main.go +++ b/private/model/cli/gen-api/main.go @@ -187,7 +187,9 @@ func writeServiceFiles(g *generateInfo, pkgDir string) { Must(writeS3ManagerUploadInputFile(g)) } - if len(g.API.SmokeTests.TestCases) > 0 { + // SMS service is deprecated and endpoints are turned off, so dont generate + // integration tests for that service. + if len(g.API.SmokeTests.TestCases) > 0 && g.API.PackageName() != "sms" { Must(writeAPISmokeTestsFile(g)) } } diff --git a/service/sms/integ_test.go b/service/sms/integ_test.go deleted file mode 100644 index 3378a300663..00000000000 --- a/service/sms/integ_test.go +++ /dev/null @@ -1,66 +0,0 @@ -// Code generated by private/model/cli/gen-api/main.go. DO NOT EDIT. - -//go:build go1.16 && integration -// +build go1.16,integration - -package sms_test - -import ( - "context" - "testing" - "time" - - "github.com/aws/aws-sdk-go/aws" - "github.com/aws/aws-sdk-go/aws/awserr" - "github.com/aws/aws-sdk-go/aws/request" - "github.com/aws/aws-sdk-go/awstesting/integration" - "github.com/aws/aws-sdk-go/service/sms" -) - -var _ aws.Config -var _ awserr.Error -var _ request.Request - -func TestInteg_00_GetConnectors(t *testing.T) { - ctx, cancelFn := context.WithTimeout(context.Background(), 5*time.Second) - defer cancelFn() - - sess := integration.SessionWithDefaultRegion("us-west-2") - svc := sms.New(sess) - params := &sms.GetConnectorsInput{} - _, err := svc.GetConnectorsWithContext(ctx, params, func(r *request.Request) { - r.Handlers.Validate.RemoveByName("core.ValidateParametersHandler") - }) - if err != nil { - t.Errorf("expect no error, got %v", err) - } -} -func TestInteg_01_DeleteReplicationJob(t *testing.T) { - ctx, cancelFn := context.WithTimeout(context.Background(), 5*time.Second) - defer cancelFn() - - sess := integration.SessionWithDefaultRegion("us-west-2") - svc := sms.New(sess) - params := &sms.DeleteReplicationJobInput{ - ReplicationJobId: aws.String("invalidId"), - } - _, err := svc.DeleteReplicationJobWithContext(ctx, params, func(r *request.Request) { - r.Handlers.Validate.RemoveByName("core.ValidateParametersHandler") - }) - if err == nil { - t.Fatalf("expect request to fail") - } - aerr, ok := err.(awserr.RequestFailure) - if !ok { - t.Fatalf("expect awserr, was %T", err) - } - if len(aerr.Code()) == 0 { - t.Errorf("expect non-empty error code") - } - if len(aerr.Message()) == 0 { - t.Errorf("expect non-empty error message") - } - if v := aerr.Code(); v == request.ErrCodeSerialization { - t.Errorf("expect API error code got serialization failure") - } -}