Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds example of S3 download with progress #2456

Merged
merged 2 commits into from Mar 1, 2019

Conversation

@petems
Copy link
Contributor

commented Feb 17, 2019

  • Uses io.WriterAt to determine progress
  • cheggaa/pb is the most popular golang progress bar libraries
  • Great example for future peoples!
@jasdel
Copy link
Member

left a comment

Thanks for taking the time to create this PR example for progress with SDK's download manager. I had a couple comments on specific items that I think we can change prior to accepting this PR.

Could you also run go fmt and goimports.

@petems petems force-pushed the petems:add_example_of_s3_get_with_progress branch 4 times, most recently from 50d02a4 to c0361e8 Feb 18, 2019

@jasdel
Copy link
Member

left a comment

Thanks for making these changes. I've added a few additional changes. Most notability I don't think we should keep the dependency on the progress bar package. Printing out the progress bytes or % instead. Mainly to avoid adding a dependency on that package to the SDK. Even though the example is wrapped in a example build tag, the dependency could still be fetched.

@petems petems force-pushed the petems:add_example_of_s3_get_with_progress branch 6 times, most recently from 8ddb54f to 6d67414 Feb 21, 2019

Adds example of S3 download with progress
* Uses io.WriterAt to determine progress
* Tracks the progress and writes to stdout 
* Great example for future peoples!

@petems petems force-pushed the petems:add_example_of_s3_get_with_progress branch from 6d67414 to 5c87f8e Feb 22, 2019

@jasdel

jasdel approved these changes Mar 1, 2019

Copy link
Member

left a comment

Thanks a lot for taking the time and effort to create and update this PR. I made a few minor tweaks to the formatting, and had the percentage output print continuously on the same line.

@jasdel jasdel merged commit 07f5610 into aws:master Mar 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jasdel added a commit that referenced this pull request Mar 1, 2019

Add recent changes to pending change log
Adds #2456 and #2343 to pending change for next release.
@aws-sdk-go-automation aws-sdk-go-automation referenced this pull request Mar 1, 2019
@petems

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

@jasdel Awesome, thanks for your help getting it over the line! 😄

@petems petems deleted the petems:add_example_of_s3_get_with_progress branch Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.