New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement xml.Unmarshaler for map #60

Merged
merged 3 commits into from Jan 11, 2015

Conversation

Projects
None yet
2 participants
@nabeken
Contributor

nabeken commented Jan 10, 2015

As you may know, XML does not handle map well like JSON does because we don't know what element value will be used as a key or as a value.

We need to implement xml.Unmarshaler interface for map.

In this PR, UnmarshalXML is generated only for query protocol because I have no idea how to detect which format is used in response.

Once this PR lands, SQS's ReceiveMessage works well with MessageAttributes馃憦

stripecodahale added a commit that referenced this pull request Jan 11, 2015

@stripecodahale stripecodahale merged commit 414ac84 into aws:master Jan 11, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@stripecodahale

This comment has been minimized.

Show comment
Hide comment
@stripecodahale

stripecodahale Jan 11, 2015

Contributor

Awesome work! Thank you!

Contributor

stripecodahale commented Jan 11, 2015

Awesome work! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment