From c8dd200dc71b4c2291c9133b315345bc57f6d3ee Mon Sep 17 00:00:00 2001 From: Dongie Agnir <261310+dagnir@users.noreply.github.com> Date: Thu, 9 May 2024 11:32:51 -0700 Subject: [PATCH] Fix SQS test (#5203) - Set explicit region in test clients - Add type inference to HashMap --- .../sqs/MessageMD5ChecksumValidationDisableTest.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/services/sqs/src/test/java/software/amazon/awssdk/services/sqs/MessageMD5ChecksumValidationDisableTest.java b/services/sqs/src/test/java/software/amazon/awssdk/services/sqs/MessageMD5ChecksumValidationDisableTest.java index 2cf7a6be8500..48aa89e46363 100644 --- a/services/sqs/src/test/java/software/amazon/awssdk/services/sqs/MessageMD5ChecksumValidationDisableTest.java +++ b/services/sqs/src/test/java/software/amazon/awssdk/services/sqs/MessageMD5ChecksumValidationDisableTest.java @@ -29,6 +29,7 @@ import software.amazon.awssdk.http.AbortableInputStream; import software.amazon.awssdk.http.HttpExecuteResponse; import software.amazon.awssdk.http.SdkHttpResponse; +import software.amazon.awssdk.regions.Region; import software.amazon.awssdk.services.sqs.internal.MessageMD5ChecksumInterceptor; import software.amazon.awssdk.services.sqs.model.MessageAttributeValue; import software.amazon.awssdk.services.sqs.model.SendMessageResponse; @@ -43,6 +44,7 @@ */ public class MessageMD5ChecksumValidationDisableTest { private static final AwsBasicCredentials CLIENT_CREDENTIALS = AwsBasicCredentials.create("ca", "cs"); + private static final Region CLIENT_REGION = Region.US_WEST_2; private static final String MESSAGE_ID = "0f433476-621e-4638-811a-112d2c2e41d7"; private MockAsyncHttpClient asyncHttpClient; @@ -65,6 +67,7 @@ public void md5ValidationEnabled_default_md5InResponse_Works() { asyncHttpClient.stubResponses(responseWithMd5()); SqsAsyncClient client = SqsAsyncClient.builder() .credentialsProvider(StaticCredentialsProvider.create(CLIENT_CREDENTIALS)) + .region(CLIENT_REGION) .httpClient(asyncHttpClient) .build(); @@ -79,6 +82,7 @@ public void md5ValidationEnabled_default_noMd5InResponse_throwsException() { asyncHttpClient.stubResponses(responseWithoutMd5()); SqsAsyncClient client = SqsAsyncClient.builder() .credentialsProvider(StaticCredentialsProvider.create(CLIENT_CREDENTIALS)) + .region(CLIENT_REGION) .httpClient(asyncHttpClient) .build(); @@ -93,6 +97,7 @@ public void md5ValidationDisabled_md5InResponse_Works() { asyncHttpClient.stubResponses(responseWithMd5()); SqsAsyncClient client = SqsAsyncClient.builder() .credentialsProvider(StaticCredentialsProvider.create(CLIENT_CREDENTIALS)) + .region(CLIENT_REGION) .httpClient(asyncHttpClient) .checksumValidationEnabled(false) .build(); @@ -108,6 +113,7 @@ public void md5ValidationDisabled_noMd5InResponse_Works() { asyncHttpClient.stubResponses(responseWithoutMd5()); SqsAsyncClient client = SqsAsyncClient.builder() .credentialsProvider(StaticCredentialsProvider.create(CLIENT_CREDENTIALS)) + .region(CLIENT_REGION) .httpClient(asyncHttpClient) .checksumValidationEnabled(false) .build(); @@ -123,6 +129,7 @@ public void sync_md5ValidationDisabled_noMd5InResponse_Works() { syncHttpClient.stubResponses(responseWithoutMd5()); SqsClient client = SqsClient.builder() .credentialsProvider(StaticCredentialsProvider.create(CLIENT_CREDENTIALS)) + .region(CLIENT_REGION) .httpClient(syncHttpClient) .checksumValidationEnabled(false) .build(); @@ -154,7 +161,7 @@ private static HttpExecuteResponse responseWithoutMd5() { } protected static Map createAttributeValues() { - Map attrs = new HashMap(); + Map attrs = new HashMap<>(); attrs.put("attribute-1", MessageAttributeValue.builder().dataType("String").stringValue("tmp").build()); return Collections.unmodifiableMap(attrs); }