Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure build works for Windows #986

Closed
shorea opened this issue Dec 31, 2018 · 12 comments
Closed

Ensure build works for Windows #986

shorea opened this issue Dec 31, 2018 · 12 comments

Comments

@shorea
Copy link
Contributor

@shorea shorea commented Dec 31, 2018

Logs from failed windows build

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   EnvironmentVariableHelperTest$Normal.testCanManuallyReset:54 expected:<"world"> but was:<null>
[ERROR]   EnvironmentVariableHelperTest$Normal.testCanUseStaticRun:42->lambda$testCanUseStaticRun$0:44 expected:<"world"> but was:<null>
[INFO]
[ERROR] Tests run: 44, Failures: 2, Errors: 0, Skipped: 0
@abrooksv
Copy link
Contributor

@abrooksv abrooksv commented Jan 2, 2019

We patched this in the toolkit. Here is the code: aws/aws-toolkit-jetbrains@409ec23#diff-8716bc75f05ded97b7c7e72fdc364ec4

@abrooksv
Copy link
Contributor

@abrooksv abrooksv commented Jan 2, 2019

@zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Jan 9, 2019

Fixed EnvironmentVariableHelperTest via #999

Here are the new tests that are broken.

[ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.192 s <<< FAILURE! - in software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClientSpiVerificationTest
[ERROR] signalsErrorViaOnErrorAndFuture(software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClientSpiVerificationTest) Time elapsed: 2.055 s <<< ERROR!
java.util.concurrent.TimeoutException
 at software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClientSpiVerificationTest.signalsErrorViaOnErrorAndFuture(NettyNioAsyncHttpClientSpiVerificationTest.java:93)
@loganom
Copy link

@loganom loganom commented Jan 10, 2019

Beyond the tests @zoewangg listed above, codegen is also failing several tests.

Is it helpful to comment with this information?

[ERROR] Failures:
[ERROR]   DocumentationBuilderTest.asyncReturnsWithoutDocsForSuccessReturn_FormatsExceptionsInUnorderedList:86 expected:<"Some service docs[

@param paramOne param one docs
@return A CompletableFuture indicating when result will be completed.<br/>
The CompletableFuture returned by this method can be completed exceptionally with the following exceptions.
<ul>
<li>FooException Foo docs</li>
<li>BarException Bar docs</li>
</ul>]
"> but was:<"Some service docs[

@param paramOne param one docs
@return A CompletableFuture indicating when result will be completed.<br/>
The CompletableFuture returned by this method can be completed exceptionally with the following exceptions.
<ul>
<li>FooException Foo docs</li>
<li>BarException Bar docs</li>
]/ul>
">
[ERROR]   DocumentationBuilderTest.asyncReturns_FormatsExceptionsInUnorderedList:66 expected:<"Some service docs[

@param paramOne param one docs
@return CompletableFuture of success<br/>
The CompletableFuture returned by this method can be completed exceptionally with the following exceptions.
<ul>
<li>FooException Foo docs</li>
<li>BarException Bar docs</li>
</ul>]
"> but was:<"Some service docs[

@param paramOne param one docs
@return CompletableFuture of success<br/>
The CompletableFuture returned by this method can be completed exceptionally with the following exceptions.
<ul>
<li>FooException Foo docs</li>
<li>BarException Bar docs</li>
]/ul>
">
[ERROR]   DocumentationBuilderTest.javadocFormattedCorrectly:40 expected:<"Some service docs[

@param paramOne param one docs
@param paramTwo param two docs
@return This returns something
@throws FooException Thrown when foo happens
@throws BarException Thrown when bar happens
@sample FooService.FooOperation
@see this thing
@see this other thing]
"> but was:<"Some service docs[

@param paramOne param one docs
@param paramTwo param two docs
@return This returns something
@throws FooException Thrown when foo happens
@throws BarException Thrown when bar happens
@sample FooService.FooOperation
@see this thing
]see this other thing
">
[ERROR]   DocumentationBuilderTest.missingValuesAreNotPresent:102 expected:<"Some service docs[
]
"> but was:<"Some service docs[
]
">
@CFJSGeek
Copy link

@CFJSGeek CFJSGeek commented Jan 20, 2019

I see a patch is ready to be reviewed and merged. Looking forward to this fix.

@zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Jan 22, 2019

@CFJSGeek There are still some tests failing. You can skip the tests when you are building the SDK using the command mvn clean install -P quick

@dbhat01
Copy link

@dbhat01 dbhat01 commented Feb 19, 2019

@zoewangg So I used mvn clean install -P quick, and the build goes to the end, but I am not sure where is the jar file that I can use? As per documentation, it says it should be in the target directory but I dont see one. I want to use this SDK jar to run the repo examples, and as per the examples documentation, it says the SDK jar has to be included in the CLASSPATH. Thanks.

@zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Feb 20, 2019

@dbhat01 which service client are you trying to use? The jar should be under the target directory in each service module. For example, if you are trying to build s3, you can find the jar from /services/s3/target folder.

You can also download the jar from maven directly. https://search.maven.org/search?q=g:%22software.amazon.awssdk%22%20AND%20a:%22s3%22

Could you point me the documentation you were referring to? We will update it to make it more clear.

@millems
Copy link
Contributor

@millems millems commented Mar 31, 2020

Just commenting to acknowledge that we're still aware this is an issue. Comments and +1s on the original question help this get prioritized.

Alexander-Kiselyov pushed a commit to Alexander-Kiselyov/aws-sdk-java-v2 that referenced this issue Aug 26, 2020
Adding convenience method that allows to replace '\n' characters with the platform-dependent ones and applying it to affected test data.
@Alexander-Kiselyov
Copy link

@Alexander-Kiselyov Alexander-Kiselyov commented Aug 26, 2020

Beyond the tests @zoewangg listed above, codegen is also failing several tests.

Is it helpful to comment with this information?

I've created a PR, which addresses this problem - could someone please take a look?

Alexander-Kiselyov pushed a commit to Alexander-Kiselyov/aws-sdk-java-v2 that referenced this issue Aug 26, 2020
Taking convenience method that performs LF conversion out into a separate utility class and reusing it in an integration test.
Alexander-Kiselyov pushed a commit to Alexander-Kiselyov/aws-sdk-java-v2 that referenced this issue Aug 29, 2020
Supplementing CHANGELOG.MD with changes' description. Clarifying necessity of using the new-change script for such actions.
Alexander-Kiselyov pushed a commit to Alexander-Kiselyov/aws-sdk-java-v2 that referenced this issue Aug 31, 2020
Adding convenience method that allows to replace '\n' characters with the platform-dependent ones and applying it to affected test data.
Supplementing CHANGELOG.MD with changes' description. Clarifying necessity of using the new-change script for such actions.
zoewangg added a commit that referenced this issue Sep 1, 2020
Adding convenience method that allows to replace '\n' characters with the platform-dependent ones and applying it to affected test data.
Supplementing CHANGELOG.MD with changes' description. Clarifying necessity of using the new-change script for such actions.
@millems
Copy link
Contributor

@millems millems commented Jul 21, 2021

This has been fixed.

@millems millems closed this Jul 21, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Jul 21, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants