New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure build works for Windows #986

Open
shorea opened this Issue Dec 31, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@shorea
Copy link
Contributor

shorea commented Dec 31, 2018

Logs from failed windows build

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   EnvironmentVariableHelperTest$Normal.testCanManuallyReset:54 expected:<"world"> but was:<null>
[ERROR]   EnvironmentVariableHelperTest$Normal.testCanUseStaticRun:42->lambda$testCanUseStaticRun$0:44 expected:<"world"> but was:<null>
[INFO]
[ERROR] Tests run: 44, Failures: 2, Errors: 0, Skipped: 0
@abrooksv

This comment has been minimized.

Copy link
Contributor

abrooksv commented Jan 2, 2019

We patched this in the toolkit. Here is the code: aws/aws-toolkit-jetbrains@409ec23#diff-8716bc75f05ded97b7c7e72fdc364ec4

@abrooksv

This comment has been minimized.

Copy link
Contributor

abrooksv commented Jan 2, 2019

@zoewangg

This comment has been minimized.

Copy link
Contributor

zoewangg commented Jan 9, 2019

Fixed EnvironmentVariableHelperTest via #999

Here are the new tests that are broken.

[ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.192 s <<< FAILURE! - in software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClientSpiVerificationTest
[ERROR] signalsErrorViaOnErrorAndFuture(software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClientSpiVerificationTest) Time elapsed: 2.055 s <<< ERROR!
java.util.concurrent.TimeoutException
 at software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClientSpiVerificationTest.signalsErrorViaOnErrorAndFuture(NettyNioAsyncHttpClientSpiVerificationTest.java:93)
@loganom

This comment has been minimized.

Copy link

loganom commented Jan 10, 2019

Beyond the tests @zoewangg listed above, codegen is also failing several tests.

Is it helpful to comment with this information?

[ERROR] Failures:
[ERROR]   DocumentationBuilderTest.asyncReturnsWithoutDocsForSuccessReturn_FormatsExceptionsInUnorderedList:86 expected:<"Some service docs[

@param paramOne param one docs
@return A CompletableFuture indicating when result will be completed.<br/>
The CompletableFuture returned by this method can be completed exceptionally with the following exceptions.
<ul>
<li>FooException Foo docs</li>
<li>BarException Bar docs</li>
</ul>]
"> but was:<"Some service docs[

@param paramOne param one docs
@return A CompletableFuture indicating when result will be completed.<br/>
The CompletableFuture returned by this method can be completed exceptionally with the following exceptions.
<ul>
<li>FooException Foo docs</li>
<li>BarException Bar docs</li>
]/ul>
">
[ERROR]   DocumentationBuilderTest.asyncReturns_FormatsExceptionsInUnorderedList:66 expected:<"Some service docs[

@param paramOne param one docs
@return CompletableFuture of success<br/>
The CompletableFuture returned by this method can be completed exceptionally with the following exceptions.
<ul>
<li>FooException Foo docs</li>
<li>BarException Bar docs</li>
</ul>]
"> but was:<"Some service docs[

@param paramOne param one docs
@return CompletableFuture of success<br/>
The CompletableFuture returned by this method can be completed exceptionally with the following exceptions.
<ul>
<li>FooException Foo docs</li>
<li>BarException Bar docs</li>
]/ul>
">
[ERROR]   DocumentationBuilderTest.javadocFormattedCorrectly:40 expected:<"Some service docs[

@param paramOne param one docs
@param paramTwo param two docs
@return This returns something
@throws FooException Thrown when foo happens
@throws BarException Thrown when bar happens
@sample FooService.FooOperation
@see this thing
@see this other thing]
"> but was:<"Some service docs[

@param paramOne param one docs
@param paramTwo param two docs
@return This returns something
@throws FooException Thrown when foo happens
@throws BarException Thrown when bar happens
@sample FooService.FooOperation
@see this thing
]see this other thing
">
[ERROR]   DocumentationBuilderTest.missingValuesAreNotPresent:102 expected:<"Some service docs[
]
"> but was:<"Some service docs[
]
">
@CFJSGeek

This comment has been minimized.

Copy link

CFJSGeek commented Jan 20, 2019

I see a patch is ready to be reviewed and merged. Looking forward to this fix.

@zoewangg

This comment has been minimized.

Copy link
Contributor

zoewangg commented Jan 22, 2019

@CFJSGeek There are still some tests failing. You can skip the tests when you are building the SDK using the command mvn clean install -P quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment