Fix blocking close method in multiplexed channel

[Arooba-git]

Hello! 🙂
This PR fixes a blocking case similar to #2145
While that issue was addressed by adding the blocking method to allowed blocking calls, BlockHound still detects another blocking close method in Http2MultiplexedChannelPool class:

This PR fixes the call. We re-ran the tests and they passed after the fix, except the one related to interruption, which we have updated according to the changes.

In addition we compared the performance (in terms of memory usage) before and after the fix:

Before

After

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[debora-ito]

Hi @Arooba-git apologies for the delay in response.

I understand you're trying to change close() to be non-blocking, but we don't think that changing to a single thread executor is the right solution, as it would impact throughput performance.

[Arooba-git]

Hi @Arooba-git apologies for the delay in response.

No worries :)

we don't think that changing to a single thread executor is the right solution, as it would impact throughput performance.

I see.. though we can set its property so that its a 'daemon' thread... no? 🤔

[debora-ito]

Still, we would like to avoid it. We don't have suggestions for now that can be addressed in this PR. You can create a new Github issue as a feature request if you'd like.

[github-actions]

It looks like this PR has not been active for more than five days. In the absence of more information, we will be closing this PR soon. Please add a comment to prevent automatic closure, or if the PR is already closed please feel free to open a new one.