Remove httpRequestTimeout and executionTimeout features #494
Conversation
| @@ -90,7 +89,6 @@ public void interruptCausedBySomethingOtherThanTimer_PropagatesInterruptToCaller | |||
|
|
|||
| ClientOverrideConfiguration overrideConfiguration = | |||
| ClientOverrideConfiguration.builder() | |||
| .totalExecutionTimeout(TimeoutTestConstants.CLIENT_EXECUTION_TIMEOUT) | |||
There was a problem hiding this comment.
How are these tests working if we don't have a timeout anymore?
There was a problem hiding this comment.
yeah, they failed along with other tests. Fixed them(adding ignore).
Running integ tests now and will wait and see if there are more failing.
zoewangg
force-pushed
the
zoewang-disableRequestExecutionTimeouts
branch
from
90a62b4
to
136567c
Compare
|
Can you explain why the timeouts were removed? |
|
The timeouts were not functioning with async clients, and we are discussing merging the async and sync code paths (assuming we can avoid latency issues). That merger would break the timeouts for sync, so we felt it best that we remove the feature rather than knowingly breaking it underneath the hood. We intend to re-add the feature at a later date before GA. Sorry about that! We know this is an important feature for a lot of people's use-cases. |
Remove httpRequestTimeout and executionTimeout