Skip to content

Conversation

@zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Nov 26, 2025

Motivation and Context

Generated ${service}EndpointResolver class, e.g., S3EndpointResolverAware, is currently not in the correct internal folder. This PR fixes it.

Package name 'software.amazon.awssdk.services.s3.auth.scheme.internal' does not correspond to the file path 'software.amazon.awssdk.services.s3.auth.scheme' 

The content of the generated file remains the same.

package software.amazon.awssdk.services.s3.auth.scheme.internal;

import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.SdkInternalApi;
import software.amazon.awssdk.services.s3.endpoints.S3EndpointProvider;

@Generated("software.amazon.awssdk:codegen")
@SdkInternalApi
public interface S3EndpointResolverAware {
    S3EndpointProvider endpointProvider();

    interface Builder {
        Builder endpointProvider(S3EndpointProvider endpointProvider);
    }
}

This change is non-breaking since it's an internal class.

@zoewangg zoewangg requested a review from a team as a code owner November 26, 2025 00:05
@zoewangg zoewangg changed the title Fix service service EndpointResolverAware file location Fix service EndpointResolverAware file location Nov 26, 2025
@zoewangg zoewangg added the changelog-not-required Indicate changelog entry is not required for a specific PR label Nov 26, 2025
@zoewangg zoewangg enabled auto-merge November 26, 2025 00:16
@zoewangg zoewangg disabled auto-merge November 26, 2025 00:17
@zoewangg zoewangg enabled auto-merge November 26, 2025 03:01
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@zoewangg zoewangg added this pull request to the merge queue Nov 26, 2025
Merged via the queue into master with commit bc9996b Nov 26, 2025
36 of 39 checks passed
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

changelog-not-required Indicate changelog entry is not required for a specific PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants