Pass null part-size to CRT when not configured #6588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Applin
added
the
no-api-surface-area-change
joviegas
reviewed
Nov 26, 2025
.../src/test/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtAsyncHttpClientTest.java
Show resolved
Hide resolved
joviegas
approved these changes
Nov 26, 2025
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the partSize is not configured on the S3AsyncClient crt builder, do not pass a default value to crt S3 Client.
Motivation and Context
Let CRT use default part size values for S3 Client when performing multipart download with range GET. For upload, CRT already uses the same default value as the SDK.
Modifications
thresholdInBytesandreadBufferSizeInBytesconfig resolution since they depend on partSize, which can now be null. Keep same default values.Testing
Added unit tests.
Manually run upload and downloads with crt client.