Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Mark config apiVersion as deprecated #685

Closed
1 task
trivikr opened this issue Nov 4, 2023 · 2 comments · Fixed by #699
Closed
1 task

[Feature]: Mark config apiVersion as deprecated #685

trivikr opened this issue Nov 4, 2023 · 2 comments · Fixed by #699
Labels
enhancement New feature or request

Comments

@trivikr
Copy link
Member

trivikr commented Nov 4, 2023

Self-service

  • I'd be willing to implement this feature

Problem

The apiVersion config is not marked as deprecated.

Example input:

import AWS from "aws-sdk";

const client = new AWS.DynamoDB({
    apiVersion: "2012-08-10",
});

Example output:

import { DynamoDB } from "@aws-sdk/client-dynamodb";

const client = new DynamoDB({
    // The transformation for apiVersion is not implemented.
    // Refer to UPGRADING.md on aws-sdk-js-v3 for changes needed.
    // Please create/upvote feature request on aws-sdk-js-codemod for apiVersion.
    apiVersion: "2012-08-10"
});

Solution

import { DynamoDB } from "@aws-sdk/client-dynamodb";

const client = new DynamoDB({
    // The key apiVersion is no longer supported in v3, and can be removed.
    // @deprecated The client uses the latest apiVersion.
    apiVersion: "2012-08-10"
});

Alternatives

N/A

Additional context

https://github.com/dolthub/dolt/blob/b5f2e96986f28b8016063b82bc876078fee21f18/.github/actions/ses-email-action/index.js#L48

@trivikr trivikr added the enhancement New feature or request label Nov 4, 2023
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant