From 2f1975d8ec9a8134ceb03be8ca204b99856bd241 Mon Sep 17 00:00:00 2001
From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Date: Fri, 13 Nov 2020 11:39:25 -0800
Subject: [PATCH] fix(logger): disable logging of raw HTTP request/response
(#1682)
---
.../src/deserializerMiddleware.spec.ts | 10 ----------
.../middleware-serde/src/deserializerMiddleware.ts | 6 ------
.../middleware-serde/src/serializerMiddleware.spec.ts | 10 ----------
packages/middleware-serde/src/serializerMiddleware.ts | 6 ------
4 files changed, 32 deletions(-)
diff --git a/packages/middleware-serde/src/deserializerMiddleware.spec.ts b/packages/middleware-serde/src/deserializerMiddleware.spec.ts
index 95afb82d2128..3f841dc9c796 100644
--- a/packages/middleware-serde/src/deserializerMiddleware.spec.ts
+++ b/packages/middleware-serde/src/deserializerMiddleware.spec.ts
@@ -85,14 +85,4 @@ describe("deserializerMiddleware", () => {
expect(logger.info).toHaveBeenCalledTimes(1);
expect(logger.info).toHaveBeenCalledWith({ output: outputWithoutMetadata });
});
-
- it("logs response if context.logger has debug function", async () => {
- const logger = ({ debug: jest.fn() } as unknown) as Logger;
-
- const response = await deserializerMiddleware(mockOptions, mockDeserializer)(mockNext, { logger })(mockArgs);
-
- expect(response).toStrictEqual(mockResponse);
- expect(logger.debug).toHaveBeenCalledTimes(1);
- expect(logger.debug).toHaveBeenCalledWith({ httpResponse: mockNextResponse.response });
- });
});
diff --git a/packages/middleware-serde/src/deserializerMiddleware.ts b/packages/middleware-serde/src/deserializerMiddleware.ts
index 116d32f5de0d..c8af8b60c8e5 100644
--- a/packages/middleware-serde/src/deserializerMiddleware.ts
+++ b/packages/middleware-serde/src/deserializerMiddleware.ts
@@ -20,12 +20,6 @@ export const deserializerMiddleware = {
expect(logger.info).toHaveBeenCalledTimes(1);
expect(logger.info).toHaveBeenCalledWith({ input: mockArgs.input });
});
-
- it("logs request if context.logger has debug function", async () => {
- const logger = ({ debug: jest.fn() } as unknown) as Logger;
-
- const response = await serializerMiddleware(mockOptions, mockSerializer)(mockNext, { logger })(mockArgs);
-
- expect(response).toStrictEqual(mockReturn);
- expect(logger.debug).toHaveBeenCalledTimes(1);
- expect(logger.debug).toHaveBeenCalledWith({ httpRequest: mockRequest });
- });
});
diff --git a/packages/middleware-serde/src/serializerMiddleware.ts b/packages/middleware-serde/src/serializerMiddleware.ts
index 284adfe94554..58d0d0e90cb2 100644
--- a/packages/middleware-serde/src/serializerMiddleware.ts
+++ b/packages/middleware-serde/src/serializerMiddleware.ts
@@ -27,12 +27,6 @@ export const serializerMiddleware =