feat(node-http-handler): configure disableConcurrentStreams in NodeHttp2Handler #2553
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2553 +/- ##
=======================================
Coverage ? 60.31%
=======================================
Files ? 513
Lines ? 27377
Branches ? 6582
=======================================
Hits ? 16512
Misses ? 10865
Partials ? 0 Continue to review full report at Codecov.
|
trivikr
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| expect(connectSpy).toHaveBeenNthCalledWith(1, `${authorityPrefix}:${port}`); | ||
| expect(connectSpy).toHaveBeenNthCalledWith(2, `${authorityPrefix}:${port2}`); | ||
| mockH2Server2.close(); | ||
| }); |
There was a problem hiding this comment.
Another unit test for "is many for same URL but concurrent stream is disabled"?
There was a problem hiding this comment.
The concurrent stream disabled tests are in their own section on line 378.
The section starts with describe("disableConcurrentStreams", () => {
The specific test mentioned is many for same URL but concurrent stream is disabled is called is many if multiple requests are made on same URL, and is on line 402.
There was a problem hiding this comment.
LGTM, but I lack the context. i'll wait for @AllanZhengYP to approve
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Fixes: #2550
Description
Adds an option to disableConcurrentStreams in NodeHttp2Handler
Example:
Testing
CI is successful
Verified that TranscribeStreaming works in parallel in demo code https://github.com/trivikr/aws-parallel-transcribe-repro/pull/1
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.