Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove @internal jsdoc tag from profile types #3452

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 21, 2022

Issue

Fixes: #3437

Description

Removes @internal jsdoc tag from profile types

Testing

$ types> yarn clean && yarn build 
...

$ cat dist-types/profile.d.ts 
export interface Profile {
    [key: string]: string | undefined;
}
export interface ParsedIniData {
    [key: string]: Profile;
}
export interface SharedConfigFiles {
    credentialsFile: ParsedIniData;
    configFile: ParsedIniData;
}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr merged commit 2d7c151 into aws:main Mar 21, 2022
@trivikr trivikr deleted the remove-internal-profile branch March 21, 2022 17:25
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.54.1 generates error TS2305 "@aws-sdk/types" has no exported member 'SharedConfigFiles' / 'ParsedIniData'
2 participants