From 94430f160be1a320f9eaf49d69f603fc2377ee8d Mon Sep 17 00:00:00 2001 From: Alex Forsyth Date: Tue, 16 Jun 2020 14:40:48 -0700 Subject: [PATCH 1/3] example config to be propagated across packages --- packages/abort-controller/package.json | 2 +- packages/abort-controller/tsconfig.build.json | 6 ++++ packages/abort-controller/tsconfig.json | 16 --------- packages/abort-controller/tsconfig.test.json | 11 ------ tsconfig.json | 34 +++++++++++++++++++ 5 files changed, 41 insertions(+), 28 deletions(-) create mode 100644 packages/abort-controller/tsconfig.build.json delete mode 100644 packages/abort-controller/tsconfig.json delete mode 100644 packages/abort-controller/tsconfig.test.json create mode 100644 tsconfig.json diff --git a/packages/abort-controller/package.json b/packages/abort-controller/package.json index e7c23ddb8278..c40b24c9a47b 100644 --- a/packages/abort-controller/package.json +++ b/packages/abort-controller/package.json @@ -6,7 +6,7 @@ "types": "./build/index.d.ts", "scripts": { "prepublishOnly": "tsc", - "pretest": "tsc -p tsconfig.test.json", + "pretest": "tsc -p tsconfig.build.json", "test": "jest" }, "author": { diff --git a/packages/abort-controller/tsconfig.build.json b/packages/abort-controller/tsconfig.build.json new file mode 100644 index 000000000000..433db29c9676 --- /dev/null +++ b/packages/abort-controller/tsconfig.build.json @@ -0,0 +1,6 @@ +{ + "extends": "../../tsconfig.json", + "compilerOptions": { + "outDir": "./build" + } +} diff --git a/packages/abort-controller/tsconfig.json b/packages/abort-controller/tsconfig.json deleted file mode 100644 index 5dc4771dee5b..000000000000 --- a/packages/abort-controller/tsconfig.json +++ /dev/null @@ -1,16 +0,0 @@ -{ - "compilerOptions": { - "module": "commonjs", - "target": "es5", - "lib": ["es5", "es2015.collection"], - "strict": true, - "sourceMap": true, - "declaration": true, - "stripInternal": true, - "rootDir": "./src", - "outDir": "./build", - "importHelpers": true, - "noEmitHelpers": true, - "incremental": true - } -} diff --git a/packages/abort-controller/tsconfig.test.json b/packages/abort-controller/tsconfig.test.json deleted file mode 100644 index 17d0f1b7321f..000000000000 --- a/packages/abort-controller/tsconfig.test.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "extends": "./tsconfig.json", - "compilerOptions": { - "sourceMap": false, - "inlineSourceMap": true, - "inlineSources": true, - "rootDir": "./src", - "outDir": "./build", - "incremental": true - } -} diff --git a/tsconfig.json b/tsconfig.json new file mode 100644 index 000000000000..8fc51d7c6709 --- /dev/null +++ b/tsconfig.json @@ -0,0 +1,34 @@ +{ + "compilerOptions": { + /** + * Must allow: + */ + "downlevelIteration": true, + "resolveJsonModule": true, + "experimentalDecorators": true, + "noUnusedParameters": false, + "removeComments": false, + + /** + * Nice to have: + */ + + // "preserveConstEnums": true, + // "declaration": true, + // "allowUnreachableCode": false, + // "pretty": true, + + "module": "commonjs", + "moduleResolution": "node", + "target": "es5", + "lib": ["es2015", "dom"], + // "rootDir": "./", + // "outDir": "./build", + "baseUrl": ".", + "paths": { + "@aws-sdk/*": ["packages/*/src", "clients/clients-*/"] + } + }, + "include": ["packages/"], + "exclude": ["node_modules/", "build/"] +} From 00d2db44c0f50b76fd87acbbb0fe30b213477d12 Mon Sep 17 00:00:00 2001 From: Alex Forsyth Date: Tue, 16 Jun 2020 14:44:37 -0700 Subject: [PATCH 2/3] update --- tsconfig.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/tsconfig.json b/tsconfig.json index 8fc51d7c6709..0fe85ad972d2 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -12,7 +12,6 @@ /** * Nice to have: */ - // "preserveConstEnums": true, // "declaration": true, // "allowUnreachableCode": false, @@ -22,8 +21,6 @@ "moduleResolution": "node", "target": "es5", "lib": ["es2015", "dom"], - // "rootDir": "./", - // "outDir": "./build", "baseUrl": ".", "paths": { "@aws-sdk/*": ["packages/*/src", "clients/clients-*/"] From b1f627a857bab596d61732096a3b2dd8fa51bbeb Mon Sep 17 00:00:00 2001 From: Alex Forsyth Date: Wed, 17 Jun 2020 08:26:40 -0700 Subject: [PATCH 3/3] update --- packages/abort-controller/package.json | 2 +- .../{tsconfig.build.json => tsconfig.test.json} | 0 tsconfig.json | 5 +++-- 3 files changed, 4 insertions(+), 3 deletions(-) rename packages/abort-controller/{tsconfig.build.json => tsconfig.test.json} (100%) diff --git a/packages/abort-controller/package.json b/packages/abort-controller/package.json index c40b24c9a47b..e7c23ddb8278 100644 --- a/packages/abort-controller/package.json +++ b/packages/abort-controller/package.json @@ -6,7 +6,7 @@ "types": "./build/index.d.ts", "scripts": { "prepublishOnly": "tsc", - "pretest": "tsc -p tsconfig.build.json", + "pretest": "tsc -p tsconfig.test.json", "test": "jest" }, "author": { diff --git a/packages/abort-controller/tsconfig.build.json b/packages/abort-controller/tsconfig.test.json similarity index 100% rename from packages/abort-controller/tsconfig.build.json rename to packages/abort-controller/tsconfig.test.json diff --git a/tsconfig.json b/tsconfig.json index 0fe85ad972d2..f5117fd7d834 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -23,9 +23,10 @@ "lib": ["es2015", "dom"], "baseUrl": ".", "paths": { - "@aws-sdk/*": ["packages/*/src", "clients/clients-*/"] + "@aws-sdk/*": ["packages/*/src"], + "@aws-sdk/clients-*": ["clients/clients-*/"] } }, "include": ["packages/"], - "exclude": ["node_modules/", "build/"] + "exclude": ["node_modules/", "packages/*/build/"] }