Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signature-v4): mock Date in SigV4 tests #2880

Merged
merged 2 commits into from Dec 23, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 7, 2021

Issue

Refs: #2879 (comment)

Description

Mock Date in SigV4 tests

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #2880 (9c7538f) into main (cac7ad0) will decrease coverage by 0.15%.
The diff coverage is n/a.

Current head 9c7538f differs from pull request most recent head f5e6dc8. Consider uploading reports for the commit f5e6dc8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
- Coverage   58.72%   58.57%   -0.16%     
==========================================
  Files         572      572              
  Lines       30632    30632              
  Branches     7541     7541              
==========================================
- Hits        17990    17943      -47     
- Misses      12642    12689      +47     
Impacted Files Coverage Δ
packages/signature-v4/src/SignatureV4.ts 64.80% <0.00%> (-35.21%) ⬇️
packages/signature-v4/src/normalizeProvider.ts 81.81% <0.00%> (-18.19%) ⬇️
packages/signature-v4/src/headerUtil.ts 41.17% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac7ad0...f5e6dc8. Read the comment docs.

@trivikr trivikr marked this pull request as draft Nov 17, 2021
@trivikr trivikr force-pushed the test-ambient-date-usage branch from d666412 to 9c7538f Compare Dec 23, 2021
@trivikr trivikr marked this pull request as ready for review Dec 23, 2021
@trivikr trivikr requested a review from a team as a code owner Dec 23, 2021
@trivikr trivikr merged commit d79de1d into aws:main Dec 23, 2021
6 checks passed
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants