Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hash-stream-node): add readableStreamHasher #3088

Merged
merged 5 commits into from Dec 10, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 9, 2021

Issue

Internal JS-2965

Description

Adds readableStreamHasher which pipes the provided stream to hashConstructor

Testing

Unit tests

Additional Context


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #3088 (1f9661f) into main (dd66d1a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3088      +/-   ##
==========================================
+ Coverage   58.72%   58.74%   +0.01%     
==========================================
  Files         571      572       +1     
  Lines       30620    30632      +12     
  Branches     7541     7541              
==========================================
+ Hits        17982    17994      +12     
  Misses      12638    12638              
Impacted Files Coverage Δ
...kages/hash-stream-node/src/readableStreamHasher.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd66d1a...1f9661f. Read the comment docs.

@trivikr trivikr marked this pull request as ready for review Dec 10, 2021
@trivikr trivikr requested a review from a team as a code owner Dec 10, 2021
trivikr added 2 commits Dec 10, 2021
The pipe will get created before await/then is called on Promise.
This way hashCalculator will consume Readable Stream if it starts
flowing before await is called.
@trivikr trivikr merged commit 943dab0 into aws:main Dec 10, 2021
6 checks passed
@trivikr trivikr deleted the hash-stream-node-stream-hasher branch Dec 10, 2021
@github-actions
Copy link

github-actions bot commented Dec 25, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants