From 93687de1d71f5ccbbeb457cf48da4acc88f222ab Mon Sep 17 00:00:00 2001
From: George Fu <kuhe@users.noreply.github.com>
Date: Mon, 1 Dec 2025 11:46:49 -0500
Subject: [PATCH] test(core/protocols): add Query error deserialization unit
 test

---
 .../protocols/query/AwsQueryProtocol.spec.ts  | 84 +++++++++++++++++++
 1 file changed, 84 insertions(+)

diff --git a/packages/core/src/submodules/protocols/query/AwsQueryProtocol.spec.ts b/packages/core/src/submodules/protocols/query/AwsQueryProtocol.spec.ts
index 170f01f29fac..5b563d860579 100644
--- a/packages/core/src/submodules/protocols/query/AwsQueryProtocol.spec.ts
+++ b/packages/core/src/submodules/protocols/query/AwsQueryProtocol.spec.ts
@@ -1,10 +1,26 @@
+import { TypeRegistry } from "@smithy/core/schema";
 import { HttpResponse } from "@smithy/protocol-http";
+import { ServiceException, ServiceExceptionOptions } from "@smithy/smithy-client";
+import { StaticErrorSchema } from "@smithy/types";
 import { describe, expect, test as it } from "vitest";
 
 import { context } from "../test-schema.spec";
 import { AwsQueryProtocol } from "./AwsQueryProtocol";
 
 describe(AwsQueryProtocol.name, () => {
+  class GiraffeServiceException extends ServiceException {
+    constructor(options: ServiceExceptionOptions) {
+      super(options);
+      Object.setPrototypeOf(this, GiraffeServiceException.prototype);
+    }
+  }
+
+  const syntheticNamespace = "smithy.ts.sdk.synthetic.com.amazonaws.giraffes";
+  TypeRegistry.for(syntheticNamespace).registerError(
+    [-3, syntheticNamespace, "GiraffeServiceException", 0, [], []] satisfies StaticErrorSchema,
+    GiraffeServiceException
+  );
+
   it("decorates service exceptions with unmodeled fields", async () => {
     const httpResponse = new HttpResponse({
       statusCode: 400,
@@ -41,4 +57,72 @@ describe(AwsQueryProtocol.name, () => {
       },
     });
   });
+
+  it("should copy Error.Code to error.name and Error.Message to error.message", async () => {
+    const httpResponse = new HttpResponse({
+      statusCode: 400,
+      headers: {},
+      body: Buffer.from(
+        "<Exception>" +
+          "<Error>" +
+          "<Type>Sender</Type>" +
+          "<Code>GiraffeServiceException</Code>" +
+          "<Message>A giraffe has eaten your umbrella</Message>" +
+          "</Error>" +
+          "</Exception>"
+      ),
+    });
+
+    const protocol = new AwsQueryProtocol({
+      version: "1999-12-31",
+      defaultNamespace: "com.amazonaws.giraffes",
+      xmlNamespace: "ns",
+    });
+
+    const actual = await protocol
+      .deserializeResponse(
+        {
+          namespace: "ns",
+          name: "Empty",
+          traits: 0,
+          input: "unit" as const,
+          output: [3, "ns", "EmptyOutput", 0, [], []],
+        },
+        context,
+        httpResponse
+      )
+      .catch((e) => {
+        return e;
+      });
+
+    const expected = Object.assign(
+      new GiraffeServiceException({
+        name: "GiraffeServiceException",
+        $fault: "client",
+        message: "A giraffe has eaten your umbrella",
+        $metadata: {
+          cfId: undefined,
+          extendedRequestId: undefined,
+          httpStatusCode: 400,
+          requestId: undefined,
+        },
+      }),
+      {
+        Type: "Sender",
+        Code: "GiraffeServiceException",
+        Error: {
+          Code: "GiraffeServiceException",
+          Message: "A giraffe has eaten your umbrella",
+          Type: "Sender",
+        },
+      }
+    );
+
+    expect(actual.constructor).toBe(expected.constructor);
+    expect(actual.name).toEqual(expected.name);
+    expect(actual.message).toEqual(expected.message);
+    expect(actual.Type).toEqual(expected.Type);
+    expect(actual.Code).toEqual(expected.Code);
+    expect(actual.Error).toEqual(expected.Error);
+  });
 });