Adding of Node.JS Domains to Error Handling Broke Simpleworkflow #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 28, 2013 09:43
…w commonly has a member variable named 'domain' in context.
|
Great catch! I'm wondering if maybe we should just solve this by picking a more appropriate name for our internal domain flag. Otherwise, SWF might not raise an exception, but it will still not function with domain support. Seems like we'd just be obscuring that problem with this patch. |
…l support domain members.
lsegal
added a commit
that referenced
this pull request
Mar 29, 2013
|
Thanks! I just did a minor refactor since we don't need to |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was in #74 that domains were added to exception handling. The existence of a domain is tested by checking the running context (this.domain) in the sequential_executor, however calls are regularly made into the AWS.SequentialExecutor object in which the context is not of the proper object (a problem all to itself), coincidentally the SimpleWorkflow often has a
domainobject attached to the request. When exceptions are thrown it is not uncommon for it to find this string. Therefore all if statementsif (this.domain)have had type-checking added. Since the require('domain') was included in this file on a context-only basis, the same notation was used throughout.