Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add customUserAgent to ConfigurationOptions #1459

Merged
merged 2 commits into from Apr 14, 2017
Merged

add customUserAgent to ConfigurationOptions #1459

merged 2 commits into from Apr 14, 2017

Conversation

ericb
Copy link
Contributor

@ericb ericb commented Apr 12, 2017

Allows setting customUserAgent configuration option in Typescript

@codecov-io
Copy link

codecov-io commented Apr 12, 2017

Codecov Report

Merging #1459 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1459     +/-   ##
=========================================
+ Coverage   95.24%   95.35%   +0.1%     
=========================================
  Files         175      176      +1     
  Lines        6209     6222     +13     
  Branches     1272     1278      +6     
=========================================
+ Hits         5914     5933     +19     
+ Misses        295      289      -6
Impacted Files Coverage Δ
lib/services/apigateway.js 100% <0%> (ø) ⬆️
lib/services/lambda.js 100% <0%> (ø)
lib/model/shape.js 94.38% <0%> (+0.08%) ⬆️
lib/util.js 93.33% <0%> (+0.09%) ⬆️
clients/lambda.js 77.77% <0%> (+1.3%) ⬆️
lib/services/iotdata.js 81.25% <0%> (+50.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de5abc0...1c462f7. Read the comment docs.

@jeskew
Copy link
Contributor

jeskew commented Apr 12, 2017

I believe this property is not exposed because we can't append anything to the user agent in a browser environment (in browsers, the SDK's user agent are sent via the X-Amz-User-Agent header). That said, I don't have any objection to exposing this property so long as that limitation is called out in documentation. Could you update the doc string to mention that the User-Agent header will only be modified in a node environment?

@ericb
Copy link
Contributor Author

ericb commented Apr 13, 2017

Thanks @jeskew - I've updated the docstring to mention both environments.

@jeskew
Copy link
Contributor

jeskew commented Apr 14, 2017

Thanks for your contribution!

@jeskew jeskew merged commit da5e7b2 into aws:master Apr 14, 2017
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants