Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useFipsEndpoint configuration #3951

Merged
merged 24 commits into from Nov 11, 2021
Merged

Add useFipsEndpoint configuration #3951

merged 24 commits into from Nov 11, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 10, 2021

This PR:

  • Adds useFipsEndpoint configuration.
  • Adds tests for useFipsEndpoint configuration.
  • Sets real region in region, and sets useFipsEndpoint to true if it was pseudo region.
  • Replaces all checks for isFipsRegion across the SDK with useFipsEndpoint.
  • Removes checks for signingRegion from legacy fips endpoint tests.
  • Reads useFipsEndpoint from environment or shared ini configuration.
Checklist
  • npm run test passes
  • changelog is added, npm run add-change
  • run npm run integration if integration test is changed

@trivikr trivikr changed the base branch from fips-region-config to master Nov 10, 2021
@trivikr trivikr marked this pull request as ready for review Nov 11, 2021
@trivikr trivikr requested a review from as a code owner Nov 11, 2021
@trivikr trivikr changed the title [WIP] Add useFipsEndpoint configuration Add useFipsEndpoint configuration Nov 11, 2021
@trivikr trivikr marked this pull request as draft Nov 11, 2021
@trivikr trivikr marked this pull request as ready for review Nov 11, 2021
@trivikr trivikr merged commit d0620c4 into aws:master Nov 11, 2021
1 check passed
@trivikr trivikr deleted the useFipsEndpoint-dev branch Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants