Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useDualstackEndpoint configuration #3957

Merged
merged 9 commits into from Nov 12, 2021
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 11, 2021

This PR:

  • Add useDualStack configuration.
  • Reads from env/shared ini if it's not passed in client configuration.
  • Enables dualstack, if legacy useDualstack is passed for S3/S3Control.
  • Adds endpoint tests for useDualStackEndpoint.
Checklist
  • npm run test passes
  • changelog is added, npm run add-change
  • run npm run integration if integration test is changed

@trivikr trivikr marked this pull request as ready for review Nov 12, 2021
@trivikr trivikr requested a review from as a code owner Nov 12, 2021
@trivikr trivikr changed the title [WIP] Add useDualstackEndpoint configuration Add useDualstackEndpoint configuration Nov 12, 2021
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Solid PR, 🚢 it!

@trivikr trivikr merged commit c578c83 into aws:master Nov 12, 2021
1 check passed
@trivikr trivikr deleted the useDualstackEndpoint-dev branch Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants