Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FIPS for S3 Outposts #3963

Merged
merged 3 commits into from Nov 16, 2021
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 16, 2021

Fixes: #3961
This PR will be made ready once #3962 is merged. Ready!

Testing

  • Unit testing.
  • Verified that URL is generated for S3 Outposts Control Plane.
Code
import AWS from "../aws-sdk-js/index.js"; // v2.1029.0

const region = "us-gov-west-1";
const useFipsEndpoint = true;
const AccountId = "123456789012";
const Bucket = `arn:aws-us-gov:s3-outposts:${region}:${AccountId}:outpost:outpost-name:bucket:bucket-name`;

const client = new AWS.S3Control({ region, useFipsEndpoint });
const req = client.getBucket({ AccountId, Bucket });
req.on('complete', function () {
  console.log({ hostname: req.httpRequest.endpoint.host });
});
req.send(function () {});
Output
{ hostname: 's3-outposts-fips.us-gov-west-1.amazonaws.com' }
Checklist
  • npm run test passes
  • changelog is added, npm run add-change

@trivikr trivikr force-pushed the fips-s3-control-outposts branch from f20728e to c077a01 Compare Nov 16, 2021
@trivikr trivikr marked this pull request as ready for review Nov 16, 2021
@trivikr trivikr requested a review from as a code owner Nov 16, 2021
@trivikr trivikr requested a review from AllanZhengYP Nov 16, 2021
@trivikr trivikr merged commit 71e97e5 into aws:master Nov 16, 2021
1 check passed
@trivikr trivikr deleted the fips-s3-control-outposts branch Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants