Currently putBucketCors fails because xml builder throws a TypeError and getBucketCors fails because cors isn't included in the signers subResources.
This patch addresses these issues.
fix CORS on s3
Can you fix the whitespace on this (make sure to remove tabs)? Thanks!
I'm curious why this behaviour is necessary. If we are not finding the rules, that seems like a bigger issue and we shouldn't mask it like this.
properly fix the s3 CORS api
fixed the api service instead of monkey patching the xml builder
Ok I have fixed it, the s3 API definition was incorrect so that's why xml was failing to build, removed the monkey patch.
I also added AllowedHeaders to CORS as defined in the spec.
Thanks, this makes much more sense. I'll work on some integration tests and merge this if everything looks good.
ExposedHeaders should be ExposeHeaders, oops
yeah that needs a test, as it was passing tests with the wrong xml just then :(
Is there something I can do to help push this along?
Add tests for #92 and update output members
I merged this via eb3b8ea and then added some tests and fixed a missing output change to getBucketCors in the above commit. Sorry about taking so long for this, had to find some time to write tests.
Thank you for the contribution!