Skip to content

Fix presigner cleanup #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2021
Merged

Fix presigner cleanup #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1335617
Update presigner to put signature on querystring
kggilmer Dec 1, 2021
4291325
Update unit tests
kggilmer Dec 1, 2021
2c20acf
Merge branch 'main' into fix-presigner-cleanup
kggilmer Dec 3, 2021
b475c1e
Merge branch 'main' into fix-presigner-cleanup
kggilmer Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...en/smithy-aws-kotlin-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/PresignerGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ class PresignerGenerator : KotlinIntegration {
ccg.render()
}

// Captures protocol-specific state needed for presigning requests
interface PresignConfigFnVisitor {
fun renderHttpMethod(writer: KotlinWriter)
fun renderQueryParameters(writer: KotlinWriter)
Expand Down Expand Up @@ -308,7 +309,7 @@ class PresignerGenerator : KotlinIntegration {
presignConfigFnVisitor.renderQueryParameters(writer)
write("durationSeconds.toLong(),")
write("${presignableOp.signBody},")
write("SigningLocation.HEADER")
write("SigningLocation.QUERY_STRING")
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions ...mithy-aws-kotlin-codegen/src/test/kotlin/aws/sdk/kotlin/codegen/PresignerGeneratorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class PresignerGeneratorTest {
httpRequestBuilder.url.parameters.build(),
durationSeconds.toLong(),
false,
SigningLocation.HEADER
SigningLocation.QUERY_STRING
)
}

Expand Down Expand Up @@ -177,7 +177,7 @@ class PresignerGeneratorTest {
httpRequestBuilder.url.parameters.build(),
durationSeconds.toLong(),
false,
SigningLocation.HEADER
SigningLocation.QUERY_STRING
)
}

Expand Down Expand Up @@ -215,7 +215,7 @@ class PresignerGeneratorTest {
httpRequestBuilder.url.parameters.build(),
durationSeconds.toLong(),
false,
SigningLocation.HEADER
SigningLocation.QUERY_STRING
)
}

Expand Down