New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting RegionEndpoint only if ServiceURL was not set, because ServiceURL value will be lost otherwise #456

Merged
merged 1 commit into from Sep 22, 2016

Conversation

Projects
None yet
2 participants
@denisivan0v
Copy link
Contributor

denisivan0v commented Sep 22, 2016

ClientConfig.RegionEndpoint setter resets the ServiceURL property value. So, if ServiceURL was set in AWSOptions.DefaultClientConfig, it's value will be lost. This PR fixes this issue.

@normj normj merged commit ea256a7 into aws:netcore-development Sep 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@normj

This comment has been minimized.

Copy link
Member

normj commented Sep 22, 2016

Thanks for the pull request. Now that .NET Core support has been GA the netcore-development branch is retired and future .NET Core pull request should be done on master. I took care of merging this pull request onto master. We'll get this fix release soon.

@denisivan0v

This comment has been minimized.

Copy link
Contributor Author

denisivan0v commented Sep 22, 2016

Sure, I will send next PRs on master if any. Thanks a lot!

@normj

This comment has been minimized.

Copy link
Member

normj commented Sep 22, 2016

Version 3.3.0.1 of the AWSSDK.Extensions.NETCore.Setup package was pushed to NuGet with this fix. Thanks again for letting us know about the issue.

@denisivan0v

This comment has been minimized.

Copy link
Contributor Author

denisivan0v commented Sep 23, 2016

Great! Will test it today.

@denisivan0v denisivan0v deleted the denisivan0v:netcore-development branch Sep 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment