Skip to content

(enhancement): Remove unnecessary LF permissions from tests infra #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2022
Merged

(enhancement): Remove unnecessary LF permissions from tests infra #1605

merged 1 commit into from
Sep 13, 2022

Conversation

@jaidisido
Copy link
Contributor

@jaidisido jaidisido commented Sep 13, 2022

Feature or Bugfix

  • Enhancement

Detail

  • LakeFormation permissions for the CodeBuild test roles should be handled outside the public repository (i.e. in our internal test infra architecture). With this change, our users won't face the cryptic LF error at deployment anymore.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido jaidisido self-assigned this Sep 13, 2022
@jaidisido jaidisido added enhancement New feature or request documentation Improvement or bugfixes on docs continuous integration labels Sep 13, 2022
@malachi-constant malachi-constant merged commit dedcccb into main Sep 13, 2022
@malachi-constant malachi-constant deleted the enhancement/test-infra-cb-test-role branch September 13, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@malachi-constant malachi-constant malachi-constant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jaidisido jaidisido

Labels

continuous integration documentation Improvement or bugfixes on docs enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaidisido @malachi-constant