fix: handled the null values in the dataframe for existing open issue-2690 #3244
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kukreti12
changed the title
Kukreti12
changed the title
Kukreti12
changed the title
Contributor
Author
|
Addressed the issue: #2690 |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
Author
|
Hello @jaidisido, |
kukushking
approved these changes
Nov 28, 2025
Contributor
|
Thank you @Kukreti12 for chasing that bug down! |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a TypeError in execute_sparql when SPARQL bindings contain NaN or non-dict values.
Adds a focused unit test to validate safe extraction of SPARQL binding values.
Changes
_neptune.py:
Update execute_sparql: safely extract cell values using a dict-type check; non-dict/NaN cells map to None.
Implementation: per-column Series.apply with _binding_value(d) to avoid type-checker issues with applymap.
test_neptune.py:
Add test_sparql_bindings_nan_safe with sanitized, non-sensitive dataset (single row).
Assert correct DataFrame shape (1, 5) and that missing checked_out maps to None.
Motivation
Prevents TypeError: argument of type 'float' is not iterable when bindings include NaN or missing values.
Validation
Unit test test_sparql_bindings_nan_safe passes locally: confirms null-safe behavior and correct value extraction.